From: Steven Rostedt <rostedt@goodmis.org>
To: sunliming <sunliming@kylinos.cn>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, kelulanainsley@gmail.com
Subject: Re: [PATCH 4/5] tracing: Delete timestamp_mode trace file
Date: Tue, 18 Oct 2022 09:26:41 -0400 [thread overview]
Message-ID: <20221018092641.0cdfd3be@gandalf.local.home> (raw)
In-Reply-To: <20221018120056.1321426-5-sunliming@kylinos.cn>
On Tue, 18 Oct 2022 20:00:55 +0800
sunliming <sunliming@kylinos.cn> wrote:
> The timestamp_mode trace file is not necessary duo to the removing of
> the absolute timestamp.
This is user space exposed API. Which means we do not just simply "remove
it". This file is the reason I kept the absolute timestamps around in the
first place. Because user space may want them.
How do you know that user space isn't using this? Is there something else
you are planning on adding that makes taking the risk we might break user
space worth while?
-- Steve
next prev parent reply other threads:[~2022-10-18 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 12:00 [PATCH 0/5] tracing: Revmoe absolute timestamp logic and interface sunliming
2022-10-18 12:00 ` [PATCH 1/5] tracing/histogram: Fix incorrect description in histogram.rst sunliming
2022-10-18 12:00 ` [PATCH 2/5] ring-buffer: Remove absolute timestamp from add_timestamp logic sunliming
2022-10-18 12:00 ` [PATCH 3/5] ring-buffer: Remove add_ts_default to simplify code sunliming
2022-10-18 12:00 ` [PATCH 4/5] tracing: Delete timestamp_mode trace file sunliming
2022-10-18 13:26 ` Steven Rostedt [this message]
2022-12-14 8:43 ` sunliming
2022-10-18 12:00 ` [PATCH 5/5] ring-buffer: Delete interface for setting absolute time stamps sunliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018092641.0cdfd3be@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kelulanainsley@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sunliming@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).