From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50BEEC4332F for ; Tue, 18 Oct 2022 10:44:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229928AbiJRKoD (ORCPT ); Tue, 18 Oct 2022 06:44:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbiJRKoA (ORCPT ); Tue, 18 Oct 2022 06:44:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1439B488E; Tue, 18 Oct 2022 03:43:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7A94F61509; Tue, 18 Oct 2022 10:43:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AB98C433C1; Tue, 18 Oct 2022 10:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666089838; bh=SDKQZtA2ebCOlVZBJ6ubvjV9UlS+3AyGrqysP2rFbzs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ayaxG0KWn0Q57kr4FMrLD8cX5OZbpbwO/kBewRUlS3y6Q+1ouUbGoUUoBezsTVZsb V8BqV+NSvstlF/5RnnoMMiGm+19fWqnIZIZo0Acf7X1YicuprlYnbYM7wrmqaVr3PQ qyC9Feo3ji7s8egjC3UthLhW5LADczraiWB7vBIpqTWqYy7xeWfXIrj7aE7rR5rq3S 0uNZU6oVDEeQJV5mDVNvUiDU7SUEAp7UhN/649vAleiDO2MqP6+wXdFDd0Svj4f5z2 57ol1Mc1aw1hiGonqvsVBVA7a578YgAr1XDmUn0FsNKT369elHyBdH2EgRl+ltd0M9 c3MivndPFc8Eg== Date: Tue, 18 Oct 2022 12:43:56 +0200 From: Frederic Weisbecker To: Stephen Rothwell Cc: "Paul E. McKenney" , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build failure after merge of the rcu tree Message-ID: <20221018104356.GB1166572@lothringen> References: <20221018102636.347615f8@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221018102636.347615f8@canb.auug.org.au> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 10:26:36AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the rcu tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > ERROR: modpost: "srcu_check_nmi_safety" [arch/x86/kvm/kvm.ko] undefined! > ERROR: modpost: "srcu_check_nmi_safety" [arch/x86/kvm/kvm-intel.ko] undefined! > ERROR: modpost: "srcu_check_nmi_safety" [arch/x86/kvm/kvm-amd.ko] undefined! > ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/rcutorture.ko] undefined! > ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/rcuscale.ko] undefined! > ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/refscale.ko] undefined! > ERROR: modpost: "srcu_check_nmi_safety" [fs/dlm/dlm.ko] undefined! > ERROR: modpost: "srcu_check_nmi_safety" [drivers/pci/controller/vmd.ko] undefined! > ERROR: modpost: "srcu_check_nmi_safety" [drivers/char/ipmi/ipmi_msghandler.ko] undefined! > ERROR: modpost: "srcu_check_nmi_safety" [drivers/gpu/drm/drm.ko] undefined! > WARNING: modpost: suppressed 10 unresolved symbol warnings because there were too many) > > Presumably caused by commit > > 54a118fce487 ("srcu: Debug NMI safety even on archs that don't require it") My bad. This commit indeed lacks this (Paul can you add the following line on that commit?): diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c index 382236dd5e46..bcd629f5f902 100644 --- a/kernel/rcu/srcutree.c +++ b/kernel/rcu/srcutree.c @@ -651,6 +651,7 @@ void srcu_check_nmi_safety(struct srcu_struct *ssp, bool nmi_safe) } WARN_ONCE(old_nmi_safe_mask != nmi_safe_mask, "CPU %d old state %d new state %d\n", sdp->cpu, old_nmi_safe_mask, nmi_safe_mask); } +EXPORT_SYMBOL_GPL(srcu_check_nmi_safety); #endif /* CONFIG_PROVE_RCU */ /* Thanks!