From: Andre Przywara <andre.przywara@arm.com>
To: Icenowy Zheng <uwu@icenowy.me>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
soc@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-phy@lists.infradead.org,
linux-usb@vger.kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 02/10] dt-bindings: phy: add binding document for Allwinner F1C100s USB PHY
Date: Mon, 24 Oct 2022 15:17:01 +0100 [thread overview]
Message-ID: <20221024151701.3dff5794@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20221012055602.1544944-3-uwu@icenowy.me>
On Wed, 12 Oct 2022 13:55:54 +0800
Icenowy Zheng <uwu@icenowy.me> wrote:
> Allwinner F1C100s has the most simple USB PHY among all Allwinner SoCs,
> because it has only one OTG USB controller, no host-only OHCI/EHCI
> controllers.
>
> Add a binding document for it. Following the current situation of one
> YAML file per SoC, this one is based on
> allwinner,sun8i-v3s-usb-phy.yaml, but with OHCI/EHCI-related bits
> removed. (The same driver in Linux, phy-sun4i-usb, covers all these
> binding files now.)
>
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> Changes in v2:
> - Clarify the relation with other phy-sun4i-usb bindings.
> - Added Rob's ACK.
>
> .../phy/allwinner,suniv-f1c100s-usb-phy.yaml | 83 +++++++++++++++++++
> 1 file changed, 83 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/allwinner,suniv-f1c100s-usb-phy.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/allwinner,suniv-f1c100s-usb-phy.yaml b/Documentation/devicetree/bindings/phy/allwinner,suniv-f1c100s-usb-phy.yaml
> new file mode 100644
> index 000000000000..22ff8e0f2331
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/allwinner,suniv-f1c100s-usb-phy.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/allwinner,suniv-f1c100s-usb-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Allwinner F1C100s USB PHY Device Tree Bindings
I see that commit dd3cb467ebb56 [1] discourages the redundant "Device Tree
Bindings" suffix in the title name, so I think you should remove that.
The rest looks alright to me, compared against the manual and what the
driver expects, so with that fixed:
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dd3cb467ebb56
> +
> +maintainers:
> + - Chen-Yu Tsai <wens@csie.org>
> + - Maxime Ripard <mripard@kernel.org>
> +
> +properties:
> + "#phy-cells":
> + const: 1
> +
> + compatible:
> + const: allwinner,suniv-f1c100s-usb-phy
> +
> + reg:
> + maxItems: 1
> + description: PHY Control registers
> +
> + reg-names:
> + const: phy_ctrl
> +
> + clocks:
> + maxItems: 1
> + description: USB OTG PHY bus clock
> +
> + clock-names:
> + const: usb0_phy
> +
> + resets:
> + maxItems: 1
> + description: USB OTG reset
> +
> + reset-names:
> + const: usb0_reset
> +
> + usb0_id_det-gpios:
> + maxItems: 1
> + description: GPIO to the USB OTG ID pin
> +
> + usb0_vbus_det-gpios:
> + maxItems: 1
> + description: GPIO to the USB OTG VBUS detect pin
> +
> + usb0_vbus_power-supply:
> + description: Power supply to detect the USB OTG VBUS
> +
> + usb0_vbus-supply:
> + description: Regulator controlling USB OTG VBUS
> +
> +required:
> + - "#phy-cells"
> + - compatible
> + - clocks
> + - clock-names
> + - reg
> + - reg-names
> + - resets
> + - reset-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/clock/suniv-ccu-f1c100s.h>
> + #include <dt-bindings/reset/suniv-ccu-f1c100s.h>
> +
> + phy@1c13400 {
> + compatible = "allwinner,suniv-f1c100s-usb-phy";
> + reg = <0x01c13400 0x10>;
> + reg-names = "phy_ctrl";
> + clocks = <&ccu CLK_USB_PHY0>;
> + clock-names = "usb0_phy";
> + resets = <&ccu RST_USB_PHY0>;
> + reset-names = "usb0_reset";
> + #phy-cells = <1>;
> + usb0_id_det-gpios = <&pio 4 2 GPIO_ACTIVE_HIGH>;
> + };
next prev parent reply other threads:[~2022-10-24 18:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 5:55 [PATCH v2 00/10] SUNIV USB and PopStick support (and updating mailmap) Icenowy Zheng
2022-10-12 5:55 ` [PATCH v2 01/10] mailmap: update Icenowy Zheng's mail address Icenowy Zheng
2022-10-12 8:31 ` Arnd Bergmann
2022-10-12 8:35 ` Icenowy Zheng
2022-10-12 8:44 ` Arnd Bergmann
2022-10-12 5:55 ` [PATCH v2 02/10] dt-bindings: phy: add binding document for Allwinner F1C100s USB PHY Icenowy Zheng
2022-10-24 14:17 ` Andre Przywara [this message]
2022-10-12 5:55 ` [PATCH v2 03/10] dt-bindings: usb: sunxi-musb: add F1C100s MUSB compatible string Icenowy Zheng
2022-10-12 13:08 ` Krzysztof Kozlowski
2022-10-12 5:55 ` [PATCH v2 04/10] phy: sun4i-usb: add support for the USB PHY on F1C100s SoC Icenowy Zheng
2022-10-12 21:21 ` Jernej Škrabec
2022-10-13 8:49 ` Icenowy Zheng
2022-10-13 18:25 ` Jernej Škrabec
2022-10-14 2:56 ` Icenowy Zheng
2022-10-12 5:55 ` [PATCH v2 05/10] musb: sunxi: add support for the F1C100s MUSB controller Icenowy Zheng
2022-10-12 21:24 ` Jernej Škrabec
2022-10-12 5:55 ` [PATCH v2 06/10] ARM: suniv: add USB-related device nodes Icenowy Zheng
2022-10-24 14:16 ` Andre Przywara
2022-10-24 14:56 ` Icenowy Zheng
2022-10-12 5:55 ` [PATCH v2 07/10] ARM: suniv: f1c100s: enable USB on Lichee Pi Nano Icenowy Zheng
2022-10-12 13:11 ` Krzysztof Kozlowski
2022-10-12 5:56 ` [PATCH v2 08/10] dt-bindings: vendor-prefixes: add Source Parts Icenowy Zheng
2022-10-12 13:08 ` Krzysztof Kozlowski
2022-10-12 5:56 ` [PATCH v2 09/10] dt-binding: arm: sunxi: add compatible strings for PopStick v1.1 Icenowy Zheng
2022-10-12 13:09 ` Krzysztof Kozlowski
2022-10-24 14:17 ` Andre Przywara
2022-10-24 14:54 ` Icenowy Zheng
2022-10-12 5:56 ` [PATCH v2 10/10] ARM: dts: suniv: add device tree " Icenowy Zheng
2022-10-12 9:34 ` Clément Péron
2022-10-12 13:11 ` Krzysztof Kozlowski
2022-10-24 14:56 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024151701.3dff5794@donnerap.cambridge.arm.com \
--to=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=soc@kernel.org \
--cc=uwu@icenowy.me \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).