From: Baokun Li <libaokun1@huawei.com>
To: <linux-ext4@vger.kernel.org>
Cc: <tytso@mit.edu>, <adilger.kernel@dilger.ca>, <jack@suse.cz>,
<ritesh.list@gmail.com>, <linux-kernel@vger.kernel.org>,
<yi.zhang@huawei.com>, <yukuai3@huawei.com>,
<libaokun1@huawei.com>
Subject: [PATCH v3 0/4] ext4: fix two bug_on in __es_tree_search
Date: Wed, 26 Oct 2022 12:23:06 +0800 [thread overview]
Message-ID: <20221026042310.3839669-1-libaokun1@huawei.com> (raw)
V1->V2:
In patch 2, when imode is not set to S_IFREG, the inode also needs
to be initialized. Otherwise, the check can be bypassed, causing
the BUG_ON. (found in the review by yangerkun)
V2->V3:
a. add EXT4_IGET_BAD flag to prevent unexpected bad inode.
b. check bad quota inode in vfs_setup_quota_inode() instead of in
ext4_quota_enable() for more generic approach to this problem.
c. add helper to check quota inums.
Baokun Li (4):
ext4: fix bug_on in __es_tree_search caused by bad quota inode
ext4: add helper to check quota inums
ext4: add EXT4_IGET_BAD flag to prevent unexpected bad inode
ext4: fix bug_on in __es_tree_search caused by bad boot loader inode
fs/ext4/ext4.h | 3 ++-
fs/ext4/inode.c | 8 +++++++-
fs/ext4/ioctl.c | 5 +++--
fs/ext4/super.c | 28 +++++++++++++++++++++++++---
fs/quota/dquot.c | 2 ++
5 files changed, 39 insertions(+), 7 deletions(-)
--
2.31.1
next reply other threads:[~2022-10-26 4:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 4:23 Baokun Li [this message]
2022-10-26 4:23 ` [PATCH v3 1/4] ext4: fix bug_on in __es_tree_search caused by bad quota inode Baokun Li
2022-10-26 9:36 ` Jan Kara
2022-10-26 13:56 ` Jason Yan
2022-10-26 18:33 ` Chaitanya Kulkarni
2022-10-26 4:23 ` [PATCH v3 2/4] ext4: add helper to check quota inums Baokun Li
2022-10-26 9:38 ` Jan Kara
2022-10-26 13:57 ` Jason Yan
2022-10-26 4:23 ` [PATCH v3 3/4] ext4: add EXT4_IGET_BAD flag to prevent unexpected bad inode Baokun Li
2022-10-26 9:41 ` Jan Kara
2022-10-26 13:59 ` Jason Yan
2022-10-26 4:23 ` [PATCH v3 4/4] ext4: fix bug_on in __es_tree_search caused by bad boot loader inode Baokun Li
2022-10-26 10:12 ` Jan Kara
2022-10-26 14:05 ` Jason Yan
2022-12-06 21:01 ` [PATCH v3 0/4] ext4: fix two bug_on in __es_tree_search Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026042310.3839669-1-libaokun1@huawei.com \
--to=libaokun1@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).