From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Wei Gong <gongwei833x@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: [PATCH v2] pci: fix device presence detection for VFs
Date: Wed, 26 Oct 2022 02:11:21 -0400 [thread overview]
Message-ID: <20221026060912.173250-1-mst@redhat.com> (raw)
virtio uses the same driver for VFs and PFs. Accordingly,
pci_device_is_present is used to detect device presence. This function
isn't currently working properly for VFs since it attempts reading
device and vendor ID. As VFs are present if and only if PF is present,
just return the value for that device.
Reported-by: Wei Gong <gongwei833x@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Wei Gong, thanks for your testing of the RFC!
As I made a small change, would appreciate re-testing.
Thanks!
changes from RFC:
use pci_physfn() wrapper to make the code build without PCI_IOV
drivers/pci/pci.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 2127aba3550b..899b3f52e84e 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -6445,8 +6445,13 @@ bool pci_devs_are_dma_aliases(struct pci_dev *dev1, struct pci_dev *dev2)
bool pci_device_is_present(struct pci_dev *pdev)
{
+ struct pci_dev *physfn = pci_physfn(pdev);
u32 v;
+ /* Not a PF? Switch to the PF. */
+ if (physfn != pdev)
+ return pci_device_is_present(physfn);
+
if (pci_dev_is_disconnected(pdev))
return false;
return pci_bus_read_dev_vendor_id(pdev->bus, pdev->devfn, &v, 0);
--
MST
next reply other threads:[~2022-10-26 6:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 6:11 Michael S. Tsirkin [this message]
2022-10-26 13:46 ` [PATCH v2] pci: fix device presence detection for VFs Wei Gong
2022-11-08 4:52 ` Wei Gong
2022-11-08 4:58 ` Michael S. Tsirkin
2022-11-08 5:06 ` Bjorn Helgaas
2022-11-10 19:35 ` Bjorn Helgaas
2022-11-10 20:15 ` Michael S. Tsirkin
2022-11-11 23:42 ` Bjorn Helgaas
2022-11-13 8:46 ` Michael S. Tsirkin
2022-11-15 16:24 ` Bjorn Helgaas
2022-11-16 11:16 ` Lukas Wunner
2022-11-17 5:36 ` Parav Pandit
2022-12-19 5:56 ` Michael S. Tsirkin
2022-12-19 8:22 ` Lukas Wunner
2022-11-11 4:00 ` Wei Gong
2022-11-08 14:53 ` Bjorn Helgaas
2022-11-08 15:02 ` Bjorn Helgaas
2022-11-08 15:19 ` Michael S. Tsirkin
2022-11-08 17:58 ` Bjorn Helgaas
2022-11-08 18:02 ` Michael S. Tsirkin
2022-11-09 4:36 ` Wei Gong
2022-11-09 5:12 ` Bjorn Helgaas
2022-11-09 7:00 ` Wei Gong
2022-11-09 7:10 ` Michael S. Tsirkin
2022-11-09 17:30 ` Bjorn Helgaas
2022-11-09 17:49 ` Michael S. Tsirkin
2022-11-11 23:39 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026060912.173250-1-mst@redhat.com \
--to=mst@redhat.com \
--cc=bhelgaas@google.com \
--cc=gongwei833x@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).