archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <>
To: Slark Xiao <>
Subject: Re: [PATCH] PCI: Add vendor ID for Quectel and Cinterion
Date: Thu, 27 Oct 2022 09:27:42 -0500	[thread overview]
Message-ID: <20221027142742.GA826519@bhelgaas> (raw)
In-Reply-To: <>

On Thu, Oct 27, 2022 at 07:51:23PM +0800, Slark Xiao wrote:
> In MHI driver, there are some companies product still
> do not have their own PCI vendor macro. So we add it
> here to make the code neat. Ref ID could be found in
> link

Rewrap to fill 75 columns.

Post along with the patch that uses the definitions.

> Signed-off-by: Slark Xiao <>
> ---
>  include/linux/pci_ids.h | 4 ++++
>  1 file changed, 4 insertions(+)
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index b362d90eb9b0..e3bfea06b90e 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -172,6 +172,10 @@
>  #define PCI_DEVICE_ID_BERKOM_A4T		0xffa4
> +#define PCI_VENDOR_ID_CINTERION		0x1269

The URL above says 0x1269 belongs to Thales.  Maybe add a comment to
that effect, similar to the one for PCI_VENDOR_ID_CB.

> +#define PCI_VENDOR_ID_QUECTEL		0x1eac

Both new definitions look like they're dropped in a random location.
Please move them so the vendor IDs in the file remain sorted by
numeric value.

>  #define PCI_VENDOR_ID_COMPAQ		0x0e11
> -- 
> 2.34.1

  reply	other threads:[~2022-10-27 14:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 11:51 [PATCH] PCI: Add vendor ID for Quectel and Cinterion Slark Xiao
2022-10-27 14:27 ` Bjorn Helgaas [this message]
2022-10-28  2:41   ` Slark Xiao
  -- strict thread matches above, loose matches on Subject: below --
2022-10-27 11:50 Slark Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221027142742.GA826519@bhelgaas \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).