From: Stefano Garzarella <sgarzare@redhat.com>
To: Dexuan Cui <decui@microsoft.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, arseny.krasnov@kaspersky.com,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, kys@microsoft.com,
haiyangz@microsoft.com, stephen@networkplumber.org,
wei.liu@kernel.org, linux-hyperv@vger.kernel.org
Subject: Re: [PATCH 1/2] vsock: remove the unused 'wait' in vsock_connectible_recvmsg()
Date: Mon, 31 Oct 2022 09:37:04 +0100 [thread overview]
Message-ID: <20221031083704.yqzz4qcrzbcqxbrw@sgarzare-redhat> (raw)
In-Reply-To: <20221028205646.28084-2-decui@microsoft.com>
On Fri, Oct 28, 2022 at 01:56:45PM -0700, Dexuan Cui wrote:
>Remove the unused variable introduced by 19c1b90e1979.
>
>Fixes: 19c1b90e1979 ("af_vsock: separate receive data loop")
>Signed-off-by: Dexuan Cui <decui@microsoft.com>
>---
> net/vmw_vsock/af_vsock.c | 2 --
> 1 file changed, 2 deletions(-)
Good catch!
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
>index ee418701cdee..d258fd43092e 100644
>--- a/net/vmw_vsock/af_vsock.c
>+++ b/net/vmw_vsock/af_vsock.c
>@@ -2092,8 +2092,6 @@ vsock_connectible_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
> const struct vsock_transport *transport;
> int err;
>
>- DEFINE_WAIT(wait);
>-
> sk = sock->sk;
> vsk = vsock_sk(sk);
> err = 0;
>--
>2.25.1
>
next prev parent reply other threads:[~2022-10-31 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 20:56 [PATCH 0/2] vsock: remove an unused variable and fix infinite sleep Dexuan Cui
2022-10-28 20:56 ` [PATCH 1/2] vsock: remove the unused 'wait' in vsock_connectible_recvmsg() Dexuan Cui
2022-10-31 8:37 ` Stefano Garzarella [this message]
2022-10-28 20:56 ` [PATCH 2/2] vsock: fix possible infinite sleep in vsock_connectible_wait_data() Dexuan Cui
2022-10-31 8:43 ` Stefano Garzarella
2022-11-01 1:58 ` Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031083704.yqzz4qcrzbcqxbrw@sgarzare-redhat \
--to=sgarzare@redhat.com \
--cc=arseny.krasnov@kaspersky.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).