From: Namhyung Kim <namhyung@kernel.org>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Song Liu <songliubraving@fb.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Martin KaFai Lau <kafai@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
Stanislav Fomichev <sdf@google.com>,
LKML <linux-kernel@vger.kernel.org>,
bpf@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: [PATCH bpf-next 3/3] bpf: Add perf_event_read_sample test cases
Date: Mon, 31 Oct 2022 22:23:40 -0700 [thread overview]
Message-ID: <20221101052340.1210239-4-namhyung@kernel.org> (raw)
In-Reply-To: <20221101052340.1210239-1-namhyung@kernel.org>
It checks the bpf_perf_event_read_sample() helper with and without buffer
for supported PERF_SAMPLE_* flags. The BPF program can control sample
data using the return value after checking the sample data and size.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
.../selftests/bpf/prog_tests/perf_sample.c | 172 ++++++++++++++++++
.../selftests/bpf/progs/test_perf_sample.c | 28 +++
2 files changed, 200 insertions(+)
create mode 100644 tools/testing/selftests/bpf/prog_tests/perf_sample.c
create mode 100644 tools/testing/selftests/bpf/progs/test_perf_sample.c
diff --git a/tools/testing/selftests/bpf/prog_tests/perf_sample.c b/tools/testing/selftests/bpf/prog_tests/perf_sample.c
new file mode 100644
index 000000000000..eee11f23196c
--- /dev/null
+++ b/tools/testing/selftests/bpf/prog_tests/perf_sample.c
@@ -0,0 +1,172 @@
+// SPDX-License-Identifier: GPL-2.0
+#define _GNU_SOURCE
+#include <stdio.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include <linux/perf_event.h>
+#include <sys/ioctl.h>
+#include <sys/mman.h>
+#include <sys/syscall.h>
+
+#include <test_progs.h>
+#include "test_perf_sample.skel.h"
+
+#ifndef noinline
+#define noinline __attribute__((noinline))
+#endif
+
+/* treat user-stack data as invalid (for testing only) */
+#define PERF_SAMPLE_INVALID PERF_SAMPLE_STACK_USER
+
+#define PERF_MMAP_SIZE 8192
+#define DATA_MMAP_SIZE 4096
+
+static int perf_fd = -1;
+static void *perf_ringbuf;
+static struct test_perf_sample *skel;
+
+static int open_perf_event(u64 sample_flags)
+{
+ struct perf_event_attr attr = {
+ .type = PERF_TYPE_SOFTWARE,
+ .config = PERF_COUNT_SW_PAGE_FAULTS,
+ .sample_type = sample_flags,
+ .sample_period = 1,
+ .disabled = 1,
+ .size = sizeof(attr),
+ };
+ int fd;
+ void *ptr;
+
+ fd = syscall(SYS_perf_event_open, &attr, 0, -1, -1, 0);
+ if (!ASSERT_GT(fd, 0, "perf_event_open"))
+ return -1;
+
+ ptr = mmap(NULL, PERF_MMAP_SIZE, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
+ if (!ASSERT_NEQ(ptr, MAP_FAILED, "mmap")) {
+ close(fd);
+ return -1;
+ }
+
+ perf_fd = fd;
+ perf_ringbuf = ptr;
+
+ return 0;
+}
+
+static void close_perf_event(void)
+{
+ if (perf_fd == -1)
+ return;
+
+ munmap(perf_ringbuf, PERF_MMAP_SIZE);
+ close(perf_fd);
+
+ perf_fd = -1;
+ perf_ringbuf = NULL;
+}
+
+static noinline void trigger_perf_event(void)
+{
+ int *buf = mmap(NULL, DATA_MMAP_SIZE, PROT_READ|PROT_WRITE, MAP_ANON|MAP_PRIVATE, -1, 0);
+
+ if (!ASSERT_NEQ(buf, MAP_FAILED, "mmap"))
+ return;
+
+ ioctl(perf_fd, PERF_EVENT_IOC_ENABLE);
+
+ /* it should generate a page fault which triggers the perf_event */
+ *buf = 1;
+
+ ioctl(perf_fd, PERF_EVENT_IOC_DISABLE);
+
+ munmap(buf, DATA_MMAP_SIZE);
+}
+
+/* check if the perf ringbuf has a sample data */
+static int check_perf_event(void)
+{
+ struct perf_event_mmap_page *page = perf_ringbuf;
+ struct perf_event_header *hdr;
+
+ if (page->data_head == page->data_tail)
+ return 0;
+
+ hdr = perf_ringbuf + page->data_offset;
+
+ if (hdr->type != PERF_RECORD_SAMPLE)
+ return 0;
+
+ return 1;
+}
+
+static void setup_perf_sample_bpf_skel(u64 sample_flags)
+{
+ struct bpf_link *link;
+
+ skel = test_perf_sample__open_and_load();
+ if (!ASSERT_OK_PTR(skel, "test_perf_sample_open_and_load"))
+ return;
+
+ skel->bss->sample_flag = sample_flags;
+ skel->bss->sample_size = sizeof(sample_flags);
+
+ link = bpf_program__attach_perf_event(skel->progs.perf_sample_filter, perf_fd);
+ if (!ASSERT_OK_PTR(link, "bpf_program__attach_perf_event"))
+ return;
+}
+
+static void clean_perf_sample_bpf_skel(void)
+{
+ test_perf_sample__detach(skel);
+ test_perf_sample__destroy(skel);
+}
+
+static void test_perf_event_read_sample_invalid(void)
+{
+ u64 flags = PERF_SAMPLE_INVALID;
+
+ if (open_perf_event(flags) < 0)
+ return;
+ setup_perf_sample_bpf_skel(flags);
+ trigger_perf_event();
+ ASSERT_EQ(check_perf_event(), 0, "number of sample");
+ clean_perf_sample_bpf_skel();
+ close_perf_event();
+}
+
+static void test_perf_event_read_sample_ip(void)
+{
+ u64 flags = PERF_SAMPLE_IP;
+
+ if (open_perf_event(flags) < 0)
+ return;
+ setup_perf_sample_bpf_skel(flags);
+ trigger_perf_event();
+ ASSERT_EQ(check_perf_event(), 1, "number of sample");
+ clean_perf_sample_bpf_skel();
+ close_perf_event();
+}
+
+static void test_perf_event_read_sample_addr(void)
+{
+ u64 flags = PERF_SAMPLE_ADDR;
+
+ if (open_perf_event(flags) < 0)
+ return;
+ setup_perf_sample_bpf_skel(flags);
+ trigger_perf_event();
+ ASSERT_EQ(check_perf_event(), 1, "number of sample");
+ clean_perf_sample_bpf_skel();
+ close_perf_event();
+}
+
+void test_perf_event_read_sample(void)
+{
+ if (test__start_subtest("perf_event_read_sample_invalid"))
+ test_perf_event_read_sample_invalid();
+ if (test__start_subtest("perf_event_read_sample_ip"))
+ test_perf_event_read_sample_ip();
+ if (test__start_subtest("perf_event_read_sample_addr"))
+ test_perf_event_read_sample_addr();
+}
diff --git a/tools/testing/selftests/bpf/progs/test_perf_sample.c b/tools/testing/selftests/bpf/progs/test_perf_sample.c
new file mode 100644
index 000000000000..79664acafcd9
--- /dev/null
+++ b/tools/testing/selftests/bpf/progs/test_perf_sample.c
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2022 Google
+
+#include <linux/bpf.h>
+#include <bpf/bpf_helpers.h>
+#include <bpf/bpf_tracing.h>
+
+unsigned long long sample_flag;
+unsigned long long sample_size;
+
+SEC("perf_event")
+int perf_sample_filter(void *ctx)
+{
+ long size;
+ unsigned long long buf[1] = {};
+
+ size = bpf_perf_event_read_sample(ctx, NULL, 0, sample_flag);
+ if (size != sample_size)
+ return 0;
+
+ if (bpf_perf_event_read_sample(ctx, buf, sizeof(buf), sample_flag) < 0)
+ return 0;
+
+ /* generate sample data */
+ return 1;
+}
+
+char _license[] SEC("license") = "GPL";
--
2.38.1.273.g43a17bfeac-goog
prev parent reply other threads:[~2022-11-01 5:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 5:23 [PATCH bpf-next 0/3] bpf: Add bpf_perf_event_read_sample() helper (v1) Namhyung Kim
2022-11-01 5:23 ` [PATCH bpf-next 1/3] perf/core: Prepare sample data before calling BPF Namhyung Kim
2022-11-01 10:03 ` Jiri Olsa
2022-11-04 6:03 ` Namhyung Kim
2022-11-01 5:23 ` [PATCH bpf-next 2/3] bpf: Add bpf_perf_event_read_sample() helper Namhyung Kim
2022-11-01 10:02 ` Jiri Olsa
2022-11-01 18:26 ` Alexei Starovoitov
2022-11-01 18:46 ` Song Liu
2022-11-01 18:52 ` Alexei Starovoitov
2022-11-01 20:04 ` Song Liu
2022-11-01 22:16 ` Namhyung Kim
2022-11-02 0:13 ` Song Liu
2022-11-02 22:18 ` Namhyung Kim
2022-11-03 18:41 ` Song Liu
2022-11-03 19:45 ` Yonghong Song
2022-11-03 20:55 ` Song Liu
2022-11-03 21:21 ` Yonghong Song
2022-11-04 6:18 ` Namhyung Kim
2022-11-01 5:23 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221101052340.1210239-4-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).