From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Beau Belgrave <beaub@linux.microsoft.com>
Cc: rostedt@goodmis.org, mathieu.desnoyers@efficios.com,
dcook@linux.microsoft.com, alanau@linux.microsoft.com,
linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] tracing/user_events: Use remote writes for event enablement
Date: Tue, 1 Nov 2022 08:55:01 +0900 [thread overview]
Message-ID: <20221101085501.443f2ac77bfb0803b91517c2@kernel.org> (raw)
In-Reply-To: <20221031164603.GB69@W11-BEAU-MD.localdomain>
On Mon, 31 Oct 2022 09:46:03 -0700
Beau Belgrave <beaub@linux.microsoft.com> wrote:
> On Mon, Oct 31, 2022 at 11:47:03PM +0900, Masami Hiramatsu wrote:
> > Hi,
> >
> > I have some comments.
> >
> > On Thu, 27 Oct 2022 15:40:10 -0700
> > Beau Belgrave <beaub@linux.microsoft.com> wrote:
> >
> > [...]
> > > @@ -1570,11 +1610,12 @@ static long user_reg_get(struct user_reg __user *ureg, struct user_reg *kreg)
> > > * Registers a user_event on behalf of a user process.
> > > */
> > > static long user_events_ioctl_reg(struct user_event_file_info *info,
> > > - unsigned long uarg)
> > > + struct file *file, unsigned long uarg)
> > > {
> > > struct user_reg __user *ureg = (struct user_reg __user *)uarg;
> > > struct user_reg reg;
> > > struct user_event *user;
> > > + struct user_event_enabler *enabler;
> > > char *name;
> > > long ret;
> > >
> > > @@ -1607,8 +1648,12 @@ static long user_events_ioctl_reg(struct user_event_file_info *info,
> > > if (ret < 0)
> > > return ret;
> > >
> > > + enabler = user_event_enabler_create(file, ®, user);
> > > +
> > > + if (!enabler)
> >
> > Shouldn't we free the user_event if needed here?
> > (I found the similar memory leak pattern in the above failure case
> > of the user_events_ref_add().)
> >
>
> user_events are shared across the entire group. They cannot be cleaned
> up until all references are gone. This is true both in this case and the
> in the user_events_ref_add() case.
>
> The pattern is to register events in the group's hashtable, then add
> them to the local file ref array that is RCU protected. If the file ref
> cannot be allocated, etc. the refcount on user is decremented. If we
> cannot create an enabler, the refcount is still held until file release.
OK, when the ioctl returns, there should be 3 cases;
- Return success, a new(existing) user_event added.
- Return error, no new user_event added.
- Return error, a new user_event added but enabler is not initialized.
And in the last case, the new user_event will be released when user
closes the file. Could you comment it here?
>
> If the event has already been added to the local file ref array, it is
> returned to prevent another reference.
I'm not sure this point. Did you mean returning an error to prevent
registering the same event again?
>
> > > + return -ENOMEM;
> > > +
> > > put_user((u32)ret, &ureg->write_index);
> > > - put_user(user->index, &ureg->status_bit);
> > >
> > > return 0;
> > > }
> > [...]
> > > @@ -1849,7 +1863,6 @@ static int user_status_open(struct inode *node, struct file *file)
> > >
> > > static const struct file_operations user_status_fops = {
> > > .open = user_status_open,
> > > - .mmap = user_status_mmap,
> >
> > So, if this drops the mmap operation, can we drop the writable flag from
> > the status tracefs file?
> >
>
> Good catch, yes I'll remove this.
Thanks!
>
> > static int create_user_tracefs(void)
> > {
> > [...]
> > /* mmap with MAP_SHARED requires writable fd */
> > emmap = tracefs_create_file("user_events_status", TRACE_MODE_WRITE,
> > NULL, NULL, &user_status_fops);
> >
> > Thank you,
> >
> > --
> > Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Thanks,
> -Beau
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2022-10-31 23:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 22:40 [RFC PATCH 0/2] tracing/user_events: Remote write ABI Beau Belgrave
2022-10-27 22:40 ` [RFC PATCH 1/2] tracing/user_events: Use remote writes for event enablement Beau Belgrave
2022-10-29 14:44 ` Mathieu Desnoyers
2022-10-31 16:38 ` Beau Belgrave
2022-10-31 14:47 ` Masami Hiramatsu
2022-10-31 16:46 ` Beau Belgrave
2022-10-31 23:55 ` Masami Hiramatsu [this message]
2022-11-01 16:45 ` Beau Belgrave
2022-10-27 22:40 ` [RFC PATCH 2/2] tracing/user_events: Fixup enable faults asyncly Beau Belgrave
2022-10-28 22:07 ` Mathieu Desnoyers
2022-10-28 22:35 ` Beau Belgrave
2022-10-29 14:23 ` Mathieu Desnoyers
2022-10-31 16:58 ` Beau Belgrave
2022-10-28 22:19 ` Mathieu Desnoyers
2022-10-28 22:42 ` Beau Belgrave
2022-10-29 14:40 ` Mathieu Desnoyers
2022-10-30 11:45 ` Mathieu Desnoyers
2022-10-31 17:18 ` Beau Belgrave
2022-10-31 17:12 ` Beau Belgrave
2022-10-28 21:50 ` [RFC PATCH 0/2] tracing/user_events: Remote write ABI Mathieu Desnoyers
2022-10-28 22:17 ` Beau Belgrave
2022-10-29 13:58 ` Mathieu Desnoyers
2022-10-31 16:53 ` Beau Belgrave
2022-11-02 13:46 ` Mathieu Desnoyers
2022-11-02 17:18 ` Beau Belgrave
2022-10-31 14:15 ` Masami Hiramatsu
2022-10-31 15:27 ` Mathieu Desnoyers
2022-10-31 17:27 ` Beau Belgrave
2022-10-31 18:25 ` Mathieu Desnoyers
2022-11-01 13:52 ` Masami Hiramatsu
2022-11-01 16:55 ` Beau Belgrave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221101085501.443f2ac77bfb0803b91517c2@kernel.org \
--to=mhiramat@kernel.org \
--cc=alanau@linux.microsoft.com \
--cc=beaub@linux.microsoft.com \
--cc=dcook@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).