linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>,
	Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
	Petr Mladek <pmladek@suse.com>,
	Joe Lawrence <joe.lawrence@redhat.com>,
	<live-patching@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	<linux-modules@vger.kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
	David Laight <David.Laight@ACULAB.COM>
Subject: [PATCH v8 5/9] kallsyms: Add helper kallsyms_on_each_match_symbol()
Date: Wed, 2 Nov 2022 16:49:17 +0800	[thread overview]
Message-ID: <20221102084921.1615-6-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20221102084921.1615-1-thunder.leizhen@huawei.com>

Function kallsyms_on_each_symbol() traverses all symbols and submits each
symbol to the hook 'fn' for judgment and processing. For some cases, the
hook actually only handles the matched symbol, such as livepatch.

Because all symbols are currently sorted by name, all the symbols with the
same name are clustered together. Function kallsyms_lookup_names() gets
the start and end positions of the set corresponding to the specified
name. So we can easily and quickly traverse all the matches.

The test results are as follows (twice): (x86)
kallsyms_on_each_match_symbol:     7454,     7984
kallsyms_on_each_symbol      : 11733809, 11785803

kallsyms_on_each_match_symbol() consumes only 0.066% of
kallsyms_on_each_symbol()'s time. In other words, 1523x better
performance.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 include/linux/kallsyms.h |  8 ++++++++
 kernel/kallsyms.c        | 18 ++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h
index 649faac31ddb162..0cd33be7142ad0d 100644
--- a/include/linux/kallsyms.h
+++ b/include/linux/kallsyms.h
@@ -69,6 +69,8 @@ static inline void *dereference_symbol_descriptor(void *ptr)
 int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *,
 				      unsigned long),
 			    void *data);
+int kallsyms_on_each_match_symbol(int (*fn)(void *, unsigned long),
+				  const char *name, void *data);
 
 /* Lookup the address for a symbol. Returns 0 if not found. */
 unsigned long kallsyms_lookup_name(const char *name);
@@ -168,6 +170,12 @@ static inline int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct
 {
 	return -EOPNOTSUPP;
 }
+
+static inline int kallsyms_on_each_match_symbol(int (*fn)(void *, unsigned long),
+						const char *name, void *data)
+{
+	return -EOPNOTSUPP;
+}
 #endif /*CONFIG_KALLSYMS*/
 
 static inline void print_ip_sym(const char *loglvl, unsigned long ip)
diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
index 48f36fd7e10b95e..0008ada2b135bef 100644
--- a/kernel/kallsyms.c
+++ b/kernel/kallsyms.c
@@ -307,6 +307,24 @@ int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *,
 	return 0;
 }
 
+int kallsyms_on_each_match_symbol(int (*fn)(void *, unsigned long),
+				  const char *name, void *data)
+{
+	int ret;
+	unsigned int i, start, end;
+
+	ret = kallsyms_lookup_names(name, &start, &end);
+	if (ret)
+		return 0;
+
+	for (i = start; !ret && i <= end; i++) {
+		ret = fn(data, kallsyms_sym_address(get_symbol_seq(i)));
+		cond_resched();
+	}
+
+	return ret;
+}
+
 static unsigned long get_symbol_pos(unsigned long addr,
 				    unsigned long *symbolsize,
 				    unsigned long *offset)
-- 
2.25.1


  parent reply	other threads:[~2022-11-02  8:50 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02  8:49 [PATCH v8 0/9] kallsyms: Optimizes the performance of lookup symbols Zhen Lei
2022-11-02  8:49 ` [PATCH v8 1/9] scripts/kallsyms: rename build_initial_tok_table() Zhen Lei
2022-11-02  8:49 ` [PATCH v8 2/9] kallsyms: Improve the performance of kallsyms_lookup_name() Zhen Lei
2022-11-02  8:49 ` [PATCH v8 3/9] kallsyms: Correctly sequence symbols when CONFIG_LTO_CLANG=y Zhen Lei
2022-11-02  8:49 ` [PATCH v8 4/9] kallsyms: Reduce the memory occupied by kallsyms_seqs_of_names[] Zhen Lei
2022-11-02 12:00   ` David Laight
2022-11-07  8:01     ` Leizhen (ThunderTown)
2022-11-02  8:49 ` Zhen Lei [this message]
2022-11-02  8:49 ` [PATCH v8 6/9] livepatch: Use kallsyms_on_each_match_symbol() to improve performance Zhen Lei
2022-11-23 13:28   ` Petr Mladek
2022-11-24  2:36     ` Leizhen (ThunderTown)
2022-11-24  8:29       ` Petr Mladek
2022-12-06 22:08       ` Luis Chamberlain
2022-12-07  1:30         ` Leizhen (ThunderTown)
2022-11-02  8:49 ` [PATCH v8 7/9] livepatch: Improve the search performance of module_kallsyms_on_each_symbol() Zhen Lei
2022-11-14  7:47   ` Jiri Olsa
2022-11-14  8:50     ` Leizhen (ThunderTown)
2022-11-14  9:27       ` Jiri Olsa
2022-11-14 10:00         ` Leizhen (ThunderTown)
2022-11-14 10:31           ` Jiri Olsa
2022-11-14 11:30             ` Leizhen (ThunderTown)
2022-11-14 13:26               ` Jiri Olsa
2022-11-14 15:46                 ` Luis Chamberlain
2022-11-15  2:10                   ` Leizhen (ThunderTown)
2022-11-15  7:30                     ` Jiri Olsa
2022-11-15  7:54                       ` Luis Chamberlain
2022-11-15  8:14                         ` Leizhen (ThunderTown)
2022-11-15 20:11                         ` Stephen Rothwell
2022-11-23 13:57   ` Petr Mladek
2022-11-24  2:41     ` Leizhen (ThunderTown)
2022-11-02  8:49 ` [PATCH v8 8/9] kallsyms: Delete an unused parameter related to kallsyms_on_each_symbol() Zhen Lei
2022-11-02  8:49 ` [PATCH v8 9/9] kallsyms: Add self-test facility Zhen Lei
2022-11-13  2:44 ` [PATCH v8 0/9] kallsyms: Optimizes the performance of lookup symbols Luis Chamberlain
2022-11-13  2:55   ` Luis Chamberlain
2022-11-14  1:25     ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221102084921.1615-6-thunder.leizhen@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mcgrof@kernel.org \
    --cc=mingo@redhat.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).