From: Nishanth Menon <nm@ti.com>
To: Jayesh Choudhary <j-choudhary@ti.com>
Cc: <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
<afd@ti.com>, <j-keerthy@ti.com>,
<krzysztof.kozlowski+dt@linaro.org>, <s-anna@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-am65-main: drop RNG clock
Date: Wed, 2 Nov 2022 10:17:06 -0500 [thread overview]
Message-ID: <20221102151706.krsi5lujydb4nswa@daybreak> (raw)
In-Reply-To: <20221031213237.52275-2-j-choudhary@ti.com>
On 03:02-20221101, Jayesh Choudhary wrote:
> Drop RNG clock property as it is not controlled by rng-driver.
Does'nt tell me what is the alternative? why is the hardware description
not sufficient for control?
https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am65x_sr2/clocks.html#clocks-for-sa2-ul0-device
Looks like a perfectly valid description - do we have a bug and firmware
does'nt allow control here?
>
> Fixes: b366b2409c97 ("arm64: dts: ti: k3-am6: Add crypto accelarator node")
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 4005a73cfea9..e166d7b7e3a1 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -126,7 +126,6 @@ rng: rng@4e10000 {
> compatible = "inside-secure,safexcel-eip76";
> reg = <0x0 0x4e10000 0x0 0x7d>;
> interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&k3_clks 136 1>;
Does this mean that the crypto module's power-domains property should be
dropped as well?
> status = "disabled"; /* Used by OP-TEE */
> };
> };
> --
> 2.25.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2022-11-02 15:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 21:32 [PATCH 0/3] RNG clock property cleanup Jayesh Choudhary
2022-10-31 21:32 ` [PATCH 1/3] arm64: dts: ti: k3-am65-main: drop RNG clock Jayesh Choudhary
2022-11-02 15:17 ` Nishanth Menon [this message]
2022-11-02 17:04 ` Andrew Davis
2022-11-02 19:44 ` Nishanth Menon
2022-11-04 18:23 ` Jayesh Choudhary
2022-10-31 21:32 ` [PATCH 2/3] arm64: dts: ti: k3-j721e-main: " Jayesh Choudhary
2022-10-31 21:32 ` [PATCH 3/3] arm64: dts: ti: k3-am64-main: " Jayesh Choudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102151706.krsi5lujydb4nswa@daybreak \
--to=nm@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-choudhary@ti.com \
--cc=j-keerthy@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).