From: Rob Herring <robh@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Sebastian Reichel <sre@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: reset: document Odroid Go Ultra power-off
Date: Wed, 2 Nov 2022 11:23:44 -0500 [thread overview]
Message-ID: <20221102162344.GA3993882-robh@kernel.org> (raw)
In-Reply-To: <20221031-b4-odroid-go-ultra-initial-v1-1-42e3dbea86d5@linaro.org>
On Mon, Oct 31, 2022 at 05:47:25PM +0100, Neil Armstrong wrote:
> The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
> to its two PMICs in order, this represents the poweroff scheme needed to complet
> a clean poeroff of the system.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../reset/hardkernel,odroid-go-ultra-poweroff.yaml | 42 ++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
> new file mode 100644
> index 000000000000..65e42258717c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Hardkernel Odroid Go Ultra poweroff
> +
> +maintainers:
> + - Neil Armstrong <neil.armstrong@linaro.org>
> +
> +description:
> + The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
> + to its two PMICs in order, this represents the poweroff scheme needed to complete
> + a clean poeroff of the system.
You don't really need a node for this. Test against the top level
compatible and then find the PMIC nodes by their compatible strings.
> +
> +properties:
> + compatible:
> + const: hardkernel,odroid-go-ultra-poweroff
> +
> + hardkernel,rk817-pmic:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the RK817 PMIC node
> +
> + hardkernel,rk818-pmic:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the RK818 PMIC node
> +
> +required:
> + - compatible
> + - hardkernel,rk817-pmic
> + - hardkernel,rk818-pmic
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + poweroff {
> + compatible = "hardkernel,odroid-go-ultra-poweroff";
> + hardkernel,rk817-pmic = <&rk817>;
> + hardkernel,rk818-pmic = <&rk818>;
> + };
>
> --
> b4 0.10.1
>
next prev parent reply other threads:[~2022-11-02 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 16:47 [PATCH 0/4] arm64: amlogic: add initial Odroid Go Ultra DTS Neil Armstrong
2022-10-31 16:47 ` [PATCH 1/4] dt-bindings: reset: document Odroid Go Ultra power-off Neil Armstrong
2022-10-31 21:16 ` Martin Blumenstingl
2022-11-02 8:47 ` Neil Armstrong
2022-11-02 16:23 ` Rob Herring [this message]
2022-11-02 16:26 ` Neil Armstrong
2022-10-31 16:47 ` [PATCH 2/4] power: reset: add Odroid Go Ultra poweroff driver Neil Armstrong
2022-10-31 22:29 ` Sebastian Reichel
2022-11-02 8:48 ` Neil Armstrong
2022-10-31 16:47 ` [PATCH 3/4] dt-bindings: amlogic: document Odroid Go Ultra compatible Neil Armstrong
2022-10-31 21:18 ` Martin Blumenstingl
2022-11-02 16:24 ` Rob Herring
2022-10-31 16:47 ` [PATCH 4/4] arm64: dts: amlogic: add initial Odroid Go Ultra DTS Neil Armstrong
2022-11-02 19:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102162344.GA3993882-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).