linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Thomson <git@johnthomson.fastmail.com.au>
To: "Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
	"Arınç ÜNAL" <arinc.unal@arinc9.com>,
	"John Crispin" <john@phrozen.org>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 0/3] mips: ralink: mt7621: fix too-early kzalloc
Date: Thu,  3 Nov 2022 15:05:35 +1000	[thread overview]
Message-ID: <20221103050538.1930758-1-git@johnthomson.fastmail.com.au> (raw)

ralink mt7621 attempts to use kzalloc before normal memory management is
available.
Before v6.1-rc1, mt7621.c soc_dev_init silently failed to kzalloc and
returned in soc_dev_init, but continued to boot without the soc device
registered.
After, kernel crashes before it outputs any console messages

This was bisected to an mm/slub change (detailed in patch 3)

RFC due to
- probably a (much) better way to do this
- do not have mt7621 device with PCIe to test
  drivers/phy/ralink/phy-mt7621-pci.c
- should this reference a commit as Fixes?




             reply	other threads:[~2022-11-03  5:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03  5:05 John Thomson [this message]
2022-11-03  5:05 ` [RFC PATCH 1/3] mips: ralink: mt7621: define MT7621_SYSC_BASE with __iomem John Thomson
2022-11-03  5:05 ` [RFC PATCH 2/3] mips: ralink: mt7621: soc queries and tests as functions John Thomson
2022-11-03  5:05 ` [RFC PATCH 3/3] mips: ralink: mt7621: do not use kzalloc too early John Thomson
2022-11-03 11:15   ` John Thomson
2022-11-03 17:25     ` Sergio Paracuellos
2022-11-04 12:29       ` Sergio Paracuellos
2022-11-04 21:12         ` John Thomson
2022-11-05  6:36           ` Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103050538.1930758-1-git@johnthomson.fastmail.com.au \
    --to=git@johnthomson.fastmail.com.au \
    --cc=arinc.unal@arinc9.com \
    --cc=john@phrozen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).