From: Aaron Tomlin <atomlin@redhat.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-modules@vger.kernel.org
Subject: Re: [PATCH 18/30] module: Use kstrtobool() instead of strtobool()
Date: Sun, 6 Nov 2022 15:03:07 +0000 [thread overview]
Message-ID: <20221106150307.ti4xd6ehh4ce2e25@ava.usersys.com> (raw)
In-Reply-To: <bb37ff26b0c748d0ca883d8f301190cd1177aad2.1667336095.git.christophe.jaillet@wanadoo.fr>
On Tue 2022-11-01 22:14 +0100, Christophe JAILLET wrote:
> strtobool() is the same as kstrtobool().
> However, the latter is more used within the kernel.
>
> In order to remove strtobool() and slightly simplify kstrtox.h, switch to
> the other function name.
>
> While at it, include the corresponding header file (<linux/kstrtox.h>)
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is part of a serie that axes all usages of strtobool().
> Each patch can be applied independently from the other ones.
>
> The last patch of the serie removes the definition of strtobool().
>
> You may not be in copy of the cover letter. So, if needed, it is available
> at [1].
>
> [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/
> ---
> kernel/module/main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index ff2dfd1f548d..79e17522e196 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -17,6 +17,7 @@
> #include <linux/fs.h>
> #include <linux/kernel.h>
> #include <linux/kernel_read_file.h>
> +#include <linux/kstrtox.h>
> #include <linux/slab.h>
> #include <linux/vmalloc.h>
> #include <linux/elf.h>
> @@ -2649,7 +2650,7 @@ static int unknown_module_param_cb(char *param, char *val, const char *modname,
> int ret;
>
> if (strcmp(param, "async_probe") == 0) {
> - if (strtobool(val, &mod->async_probe_requested))
> + if (kstrtobool(val, &mod->async_probe_requested))
> mod->async_probe_requested = true;
> return 0;
> }
> --
> 2.34.1
>
Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>
--
Aaron Tomlin
next prev parent reply other threads:[~2022-11-06 15:04 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 21:05 [PATCH 00/30] Remove strtobool() Christophe JAILLET
2022-11-01 21:13 ` [PATCH 01/30] net: usb: Use kstrtobool() instead of strtobool() Christophe JAILLET
2022-11-02 3:27 ` Jakub Kicinski
2022-11-01 21:13 ` [PATCH 02/30] wifi: " Christophe JAILLET
2022-11-08 7:39 ` Kalle Valo
2022-11-01 21:13 ` [PATCH 03/30] irqchip: " Christophe JAILLET
2022-11-26 12:46 ` Marc Zyngier
2022-11-26 15:16 ` Christophe JAILLET
2022-11-01 21:13 ` [PATCH 04/30] scsi: target: " Christophe JAILLET
2022-11-02 5:54 ` Chaitanya Kulkarni
2022-11-08 3:54 ` Martin K. Petersen
2022-11-17 18:29 ` Martin K. Petersen
2022-11-01 21:13 ` [PATCH 05/30] nvdimm: " Christophe JAILLET
2022-11-01 21:13 ` [PATCH 06/30] nvme: " Christophe JAILLET
2022-11-02 5:52 ` Chaitanya Kulkarni
2022-11-02 6:47 ` Christoph Hellwig
2022-11-02 6:57 ` Christophe JAILLET
2022-11-02 6:58 ` Christoph Hellwig
2022-11-02 7:05 ` Julia Lawall
2022-11-01 21:13 ` [PATCH 07/30] usb: core: " Christophe JAILLET
2022-11-01 21:13 ` [PATCH 08/30] usb: gadget: " Christophe JAILLET
2022-11-01 21:13 ` [PATCH 09/30] ACPI: sysfs: " Christophe JAILLET
2022-11-02 11:33 ` Andy Shevchenko
2022-11-03 18:48 ` Rafael J. Wysocki
2022-11-01 21:13 ` [PATCH 10/30] clocksource/drivers/arm_arch_timer: " Christophe JAILLET
2022-11-02 10:56 ` Mark Rutland
2022-12-02 12:17 ` Daniel Lezcano
2022-11-01 21:13 ` [PATCH 11/30] greybus: svc: " Christophe JAILLET
2022-11-01 21:49 ` Alex Elder
2022-11-02 7:31 ` Johan Hovold
2022-11-01 21:14 ` [PATCH 12/30] input: " Christophe JAILLET
2022-11-03 20:46 ` Dmitry Torokhov
2022-11-03 21:37 ` Christophe JAILLET
2022-11-07 19:40 ` Dmitry Torokhov
2022-11-01 21:14 ` [PATCH 13/30] platform/chrome: " Christophe JAILLET
2022-11-02 4:30 ` patchwork-bot+chrome-platform
2022-11-02 12:30 ` patchwork-bot+chrome-platform
2022-11-01 21:14 ` [PATCH 14/30] powercap: " Christophe JAILLET
2022-11-03 18:39 ` Rafael J. Wysocki
2022-11-01 21:14 ` [PATCH 15/30] video: fbdev: omapfb: " Christophe JAILLET
2022-11-01 21:14 ` [PATCH 16/30] cifs: " Christophe JAILLET
2022-11-01 21:14 ` [PATCH 17/30] initramfs: " Christophe JAILLET
2022-11-01 21:14 ` [PATCH 18/30] module: " Christophe JAILLET
2022-11-02 18:41 ` Luis Chamberlain
2023-01-14 13:32 ` Christophe JAILLET
2022-11-06 15:03 ` Aaron Tomlin [this message]
2023-01-17 15:39 ` Luis Chamberlain
2022-11-01 21:14 ` [PATCH 19/30] kernel/params.c: " Christophe JAILLET
2022-11-01 21:14 ` [PATCH 20/30] mm/damon: " Christophe JAILLET
2022-11-01 22:00 ` SeongJae Park
2022-11-01 21:14 ` [PATCH 21/30] mm: " Christophe JAILLET
2022-11-01 22:47 ` Kees Cook
2022-11-02 11:29 ` Andy Shevchenko
2022-11-05 2:58 ` Pasha Tatashin
2022-11-01 21:14 ` [PATCH 22/30] Bluetooth: hci_debugfs: " Christophe JAILLET
2022-11-01 21:14 ` [PATCH 23/30] test_firmware: " Christophe JAILLET
2022-11-01 21:14 ` [PATCH 24/30] arm64: cpufeature: " Christophe JAILLET
2022-11-02 13:46 ` Catalin Marinas
2023-01-14 13:29 ` Christophe JAILLET
2023-01-16 18:40 ` Catalin Marinas
2022-11-01 21:14 ` [PATCH 25/30] KVM: arm64: vgic-v3: " Christophe JAILLET
2022-11-01 21:14 ` [PATCH 26/30] s390/ipl: " Christophe JAILLET
2022-11-08 14:53 ` Alexander Gordeev
2022-11-01 21:14 ` [PATCH 27/30] KVM: x86/mmu: " Christophe JAILLET
2022-11-01 21:14 ` [PATCH 28/30] x86/xen: " Christophe JAILLET
2022-11-01 23:11 ` Boris Ostrovsky
2022-11-01 21:14 ` [PATCH 29/30] driver core: " Christophe JAILLET
2022-11-01 21:14 ` [PATCH 30/30] kstrtox: Remove strtobool() Christophe JAILLET
2022-11-01 21:18 ` Christophe JAILLET
2022-11-02 11:18 ` [PATCH 00/30] " Andy Shevchenko
2023-01-20 18:18 ` (subset) " Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221106150307.ti4xd6ehh4ce2e25@ava.usersys.com \
--to=atomlin@redhat.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).