From: JunDong Song <jundongsong1@gmail.com>
To: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
lpieralisi@kernel.org
Cc: robh@kernel.org, kw@linux.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
JunDong Song <jundongsong1@gmail.com>
Subject: [PATCH 2/2] PCI: dwc-host: Add a warning to prevent invalid values
Date: Mon, 7 Nov 2022 23:31:08 +0800 [thread overview]
Message-ID: <20221107153108.5770-2-jundongsong1@gmail.com> (raw)
In-Reply-To: <20221107153108.5770-1-jundongsong1@gmail.com>
of_pci_get_max_link_speed() may return a negative value,
causing the controller to not set the speed correctly.
Add a warning in case the driver engineer misses it.
Signed-off-by: JunDong Song <jundongsong1@gmail.com>
---
When I use the pcie dwc driver, the controller speed is abnormal,
but it has not been detected because of the @max-link-speed error,
so I think I need to return an error or warning here.
Thanks.
drivers/pci/controller/dwc/pcie-designware-host.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index 39f3b37d4..0103b9a63 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -429,8 +429,11 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)
pp->io_base = pci_pio_to_address(win->res->start);
}
- if (pci->link_gen < 1)
+ if (pci->link_gen < 1) {
pci->link_gen = of_pci_get_max_link_speed(np);
+ if (unlikely(pci->link_gen < 0))
+ dev_warn(dev, "Failed to get max link speed\n");
+ }
/* Set default bus ops */
bridge->ops = &dw_pcie_ops;
--
2.25.1
next prev parent reply other threads:[~2022-11-07 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 15:31 [PATCH 1/2] PCI: dwc-host: Add a warning to prevent invalid values JunDong Song
2022-11-07 15:31 ` JunDong Song [this message]
2022-11-10 21:32 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107153108.5770-2-jundongsong1@gmail.com \
--to=jundongsong1@gmail.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).