From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 99F57C433FE
	for <linux-kernel@archiver.kernel.org>; Mon,  7 Nov 2022 20:54:14 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233067AbiKGUyN (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 7 Nov 2022 15:54:13 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43894 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232191AbiKGUyL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 7 Nov 2022 15:54:11 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FCE15F40
        for <linux-kernel@vger.kernel.org>; Mon,  7 Nov 2022 12:54:10 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id D645AB816A0
        for <linux-kernel@vger.kernel.org>; Mon,  7 Nov 2022 20:54:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D43DC433D6;
        Mon,  7 Nov 2022 20:54:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1667854447;
        bh=imEkwKJJvU1UO54Y2mHW8PLJBKSEvCTZ91B6qYkCO30=;
        h=Date:From:To:Cc:Subject:In-Reply-To:From;
        b=nkwqEiqZLWe8aigDmczpGxIZOuHgvLzZR9UH6uWXTD2ckRChIwDIMCxR+WYp4Kwfg
         AfylPCiFayEML+Q7yURI2dybv9juXm2wrURt2UDm01VJLUqN/p6u2LyaLmNTUcvP3t
         iUbEMILgk4W7YTdE+Jcr+DPNQJEHenkDvPGN1lQ9IF/MvagjJ/T/Fx63MC+QtTn0u0
         w//yk32F2V7AgWREerpq06HLoN5qeYBOF9Q+kdJHe05ZI8E2jaF5JnvD8niV0LU3ny
         RFHxtkDLHhigEOzKjtu63KlG6BwxdJ9TOoH5dAAxwSBFe6DpwyYYxGlwLK+bA1tavL
         elWONZyccVgNw==
Date:   Mon, 7 Nov 2022 14:54:05 -0600
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Peter Collingbourne <pcc@google.com>
Cc:     Joe Perches <joe@perches.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Whitcroft <apw@canonical.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Kees Cook <keescook@chromium.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] checkpatch: add warning for non-lore mailing list URLs
Message-ID: <20221107205405.GA419220@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMn1gO7tEF+VioB8n0=8vQ4gRPKqSSfPwmbX8ci82D=hBbcfyw@mail.gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 03, 2022 at 06:34:31PM -0700, Peter Collingbourne wrote:
> On Thu, Nov 3, 2022 at 6:27 PM Joe Perches <joe@perches.com> wrote:
> > On Thu, 2022-11-03 at 18:07 -0700, Peter Collingbourne wrote:
> > > On Wed, Oct 19, 2022 at 03:28:43PM -0500, Bjorn Helgaas wrote:
> > > > From: Bjorn Helgaas <bhelgaas@google.com>
> > > >
> > > > The lkml.org, marc.info, spinics.net, etc archives are not quite as useful
> > > > as lore.kernel.org because they use different styles, add advertising, and
> > > > may disappear in the future.  The lore archives are more consistent and
> > > > more likely to stick around, so prefer https://lore.kernel.org URLs when
> > > > they exist.
> > >
> > > If the commit message contains a line like:
> > >
> > > Cc: linux-arm-kernel@lists.infradead.org
> > >
> > > this patch causes checkpatch.pl to complain. Would it be possible to
> > > restrict this to URLs?
> >
> > Yes, I believe this would probably work well enough:
> > ---
> >  scripts/checkpatch.pl | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 7be93c3df2bcb..fe25642d8bacc 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -3336,7 +3336,8 @@ sub process {
> >                 }
> >
> >  # Check for mailing list archives other than lore.kernel.org
> > -               if ($rawline =~ m{\b$obsolete_archives}) {
> > +               if ($rawline =~ m{\b$obsolete_archives} &&
> > +                   $rawline !~ /^\s*cc:/i) {
> 
> Can we make this (to|cc): instead? Otherwise developers (like me) who
> use custom scripts to add To: headers to their patches before passing
> them to checkpatch.pl will also hit this warning if their patch is
> being sent To: one of these mailing lists.

Why not make it look for "http" instead of the absence of "cc"?