From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0A6AC4332F for ; Tue, 8 Nov 2022 12:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234242AbiKHMqZ (ORCPT ); Tue, 8 Nov 2022 07:46:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233923AbiKHMqX (ORCPT ); Tue, 8 Nov 2022 07:46:23 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A55B52892 for ; Tue, 8 Nov 2022 04:46:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667911582; x=1699447582; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yInpcuBqffNpHyEIyvcFabmM7Yq7M2fOh2s3ydZG1aI=; b=EgrUu4+lFEHjZaTsop4n9Pfpmf4en4wLkYLz3jOBF/PF2N921Z8fBWp3 JNbkI4GfDBOemmjkIpu15eBSLyWzGqJzd3lS+gC8EBtIAkHMT7W4QhRBP 54SpafbE1eTLXHNnLdu9Bt/Lc1MHyriAhRc6ccd16BZStS8qiJg9sGe02 p+Usb1ZrohNj6qcjrO52YZUni9yyIaKvTe8wZgUqD8fem/t3amy7R/kZb ra6RXox3FJ3C229Pz7cYp19R2hhO3yMTXDmsudmnurml5EfN6LhPkyx0B +cVFeK9cg4R2pWcHH52tnGnjKG3czrzLFpPJws/TALdCC7M+83TnLbkZ4 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="337410746" X-IronPort-AV: E=Sophos;i="5.96,147,1665471600"; d="scan'208";a="337410746" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2022 04:46:22 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="778913220" X-IronPort-AV: E=Sophos;i="5.96,147,1665471600"; d="scan'208";a="778913220" Received: from joe-255.igk.intel.com (HELO localhost) ([172.22.229.67]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2022 04:46:17 -0800 Date: Tue, 8 Nov 2022 13:46:14 +0100 From: Stanislaw Gruszka To: Oded Gabbay Cc: David Airlie , Daniel Vetter , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jason Gunthorpe , John Hubbard , Alex Deucher , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Yuji Ishikawa , Jiho Chu , Daniel Stone , Tvrtko Ursulin , Jeffrey Hugo , Christoph Hellwig , Kevin Hilman , Jagan Teki , Jacek Lawrynowicz , Maciej Kwapulinski , Randy Dunlap Subject: Re: [RFC PATCH v3 1/3] drivers/accel: define kconfig and register a new major Message-ID: <20221108124614.GA6397@linux.intel.com> References: <20221106210225.2065371-1-ogabbay@kernel.org> <20221106210225.2065371-2-ogabbay@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221106210225.2065371-2-ogabbay@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 06, 2022 at 11:02:23PM +0200, Oded Gabbay wrote: > Add a new Kconfig for the accel subsystem. The Kconfig currently > contains only the basic CONFIG_DRM_ACCEL option that will be used to > decide whether to compile the accel registration code. Therefore, the > kconfig option is defined as bool. > > The accel code will be compiled as part of drm.ko and will be called > directly from the DRM core code. The reason we compile it as part of > drm.ko and not as a separate module is because of cyclic dependency > between drm.ko and the separate module (if it would have existed). > This is due to the fact that DRM core code calls accel functions and > vice-versa. > > The accelerator devices will be exposed to the user space with a new, > dedicated major number - 261. > > The accel init function registers the new major number as a char device > and create corresponding sysfs and debugfs root entries, similar to > what is done in DRM init function. > > I added a new header called drm_accel.h to include/drm/, that will hold > the prototypes of the drm_accel.c functions. In case CONFIG_DRM_ACCEL > is set to 'N', that header will contain empty inline implementations of > those functions, to allow DRM core code to compile successfully > without dependency on CONFIG_DRM_ACCEL. > > I Updated the MAINTAINERS file accordingly with the newly added folder > and I have taken the liberty to appropriate the dri-devel mailing list > and the dri-devel IRC channel for the accel subsystem. > > Signed-off-by: Oded Gabbay Tested-by: Stanislaw Gruszka I tested those patches with intel_vpu driver. After initial troubles, I got things worked with our driver and user mode components. Regards Stanislaw