From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F223C4332F for ; Thu, 10 Nov 2022 16:20:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231162AbiKJQU5 (ORCPT ); Thu, 10 Nov 2022 11:20:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbiKJQUy (ORCPT ); Thu, 10 Nov 2022 11:20:54 -0500 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 977A91A052 for ; Thu, 10 Nov 2022 08:20:52 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id t25so6242891ejb.8 for ; Thu, 10 Nov 2022 08:20:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:message-id:date:from:content-transfer-encoding:mime-version :subject:from:to:cc:subject:date:message-id:reply-to; bh=DeTQBsnVil4skLVb0JTYA0ze/q8Y7Qzt3eBgeJWs+Xo=; b=GKJkmTIUnrs5ihbdB9mi5Xs1cdxoZafh9Hi5mwHvDqnRpzX1Kv7B2F0E7otQXIbQaw drCybDDsVpM3uH8w2nuxWkc14OrMf1+ciOQQI0ya/CoWunaxOxkN3hPVHCNtlnue2gFk 52fMkaORsXWbzseWYaPLOVKIDJcfT2ricES00= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:message-id:date:from:content-transfer-encoding:mime-version :subject:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DeTQBsnVil4skLVb0JTYA0ze/q8Y7Qzt3eBgeJWs+Xo=; b=i4r5B6aAsiquKTzu6BSzK8xjan1DfsWHj0xK3CEEfNjRUk1uUny9CY4J5J8wTw25m6 Jo4SxUpG/A6zu0RPa28QdsPULR7cyzD4kh2bmAqnKiXaOqSGZQZwTcw1UtLij3OK4J04 N8h8zkXAGiLSbXivqU2BxuKsywMUMYjy0x0hO9wkb3eaP1WkgfG8seBmQHqE94FENEb6 vVWhdJt481+0BtvFu8CV2ctfGwckzS1UaHTh5C5sGJ0Ut4vcMosQ+omRnBYVtE9YCr5V Xz9Nh2/pRGtR3KpD00gAxRYP7Bne/PpeShIez8FEo8Cyx4lAs7c/1KTu6AAK10rzZ+KT 2Vbg== X-Gm-Message-State: ACrzQf2Env19wjLKO/KDpuULHigZzClHtZ4WiQpAeOMkw7+suA6/ZGm9 B+7iiu8fnlS0qqHMUu/kEBPSmw== X-Google-Smtp-Source: AMsMyM7Dt/Oikt/kQR0FcIfkSY10NFM7DFTTRHXFPDf41TQumRWAX1p856DgQOmzzDxBxwNbjj+v+A== X-Received: by 2002:a17:906:8b81:b0:7ad:93d1:5eae with SMTP id nr1-20020a1709068b8100b007ad93d15eaemr62378695ejc.29.1668097251178; Thu, 10 Nov 2022 08:20:51 -0800 (PST) Received: from alco.roam.corp.google.com (80.71.134.83.ipv4.parknet.dk. [80.71.134.83]) by smtp.gmail.com with ESMTPSA id e8-20020a170906314800b0077b2b0563f4sm7510193eje.173.2022.11.10.08.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 08:20:50 -0800 (PST) Subject: [PATCH v5 0/1] i2c: Restore power status of device if probe fail or device is removed MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-b4-tracking: H4sIANYkbWMC/3XOzQ6CMAwH8FcxOzuzjQ2YJ9/DeNhHgSXAkk1mDOHdrR4NnJo2/f3blWRIATK5nl aSoIQc4oyNOp+IG8zcAw0eeyKYEJwzTYNw9GVCAWpANx0Y3nGrCO5bk4HaZGY3oJiXccThEPIzpvcv v3As972owimj4BtmtLZaM39zQ4pTWKZLTD15YFARh1ggZo1SzHbCG+d2cHWIK8S+rRV3Vtq23bssD7 H8vi2lrmUt2qqyf3jbtg/GVtNkYQEAAA== From: Ricardo Ribalda Date: Thu, 10 Nov 2022 17:20:38 +0100 Message-Id: <20221109-i2c-waive-v5-0-2839667f8f6a@chromium.org> To: Wolfram Sang , Tomasz Figa , "Rafael J. Wysocki" Cc: Hidenori Kobayashi , stable@vger.kernel.org, linux-i2c@vger.kernel.org, Ricardo Ribalda , Sergey Senozhatsky , Sakari Ailus , linux-kernel@vger.kernel.org X-Mailer: b4 0.11.0-dev-d93f8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1794; i=ribalda@chromium.org; h=from:subject:message-id; bh=4clQAZaLvuRcOY86HZLxZyhWxEsEPqsm3+62UqWakNo=; b=owEBbQKS/ZANAwAKAdE30T7POsSIAcsmYgBjbSTY+Kf+2Fhq4xTRwy1lq5DVpEm/1XKcBs3SBnbD PPrVTMaJAjMEAAEKAB0WIQREDzjr+/4oCDLSsx7RN9E+zzrEiAUCY20k2AAKCRDRN9E+zzrEiPEZD/ 9qBU465i41cAV/uiiHV6bOJFvKo8YJXGpn6qLRZaJFt+tP6IIh1WXuPblF38hOKMfF0V3FE115nk/1 1qUdUX3UdHWsM9mtXdvS9uhoJTTJRC2H/0jSsY3etzA9nGlcRL3thGo5RMW4JsA+3QJhhv5xCshMoZ A6CAJkGJpKnodStNfMO2/WtpsrIeMDMIq3p1cbCosxgvG+D1+upNle++lncnzl2Li5TNT+Zhtd3lmz 9iSjuzMNwICb+15q1SIdhaGLEUQIK/0Gjhsewq8KI9uzaCmYQ852WTmnvKCpxbG0DVAe0ieTKOtBd8 OxD0h5zp2B4w7l/fdG+fHIwH62+2c5vO9mdvBFQNR9uKPDhOJ8zN5alyJ+Gn76cMzXGICbw9HkJ9m2 Q5Jg6h/8eFj3Fp+1kTZz9nPGi4WjIIS6PP5dWSzkDkxXGaJ+EBo8xeX5DMNo3maBv1xcRzjnxTsXXK 0MYWyxifouuDaOdabiU+mdmLDGfnZsPi+XjKDgJW3qrEmrM7uYNrF2FIpY6hO+pQrs59uz+PFVHlvS Z2yoAxZBjrL0sdahub533nPRvvI/0wXC61UaGwcR9Kj+Rqf3IivTPYE8FzHXXDxKA9nv1+Eu8TlVVq Vv7okpeMb4/zPyQUpG/KoixIyKAL/Qqcffj/GauplsZV5BSSH9v+neknhj6g== X-Developer-Key: i=ribalda@chromium.org; a=openpgp; fpr=9EC3BB66E2FC129A6F90B39556A0D81F9F782DA9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We have discovered that some power lines were always on even if the devices on that power line was not used. This happens because we failed to probe a device on the i2c bus, and the ACPI Power Resource were never turned off. This patch tries to fix this issue. To: Wolfram Sang To: Sakari Ailus To: Tomasz Figa To: "Rafael J. Wysocki" Cc: Hidenori Kobayashi Cc: Sergey Senozhatsky Cc: linux-i2c@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Signed-off-by: Ricardo Ribalda --- Changes in v5: - Add Cc: stable - Add Reviewed-by Sakary (Thanks!) - Renamed turn-off as power-off, in the name of consistency (Thanks Sergey!) - Link to v4: https://lore.kernel.org/r/20221109-i2c-waive-v4-0-e4496462833b@chromium.org Changes in v4: - Rename full_power to do_power_on - Link to v3: https://lore.kernel.org/r/20221109-i2c-waive-v3-0-d8651cb4b88d@chromium.org Changes in v3: - Introduce full_power variable to make more clear what we are doing. - Link to v2: https://lore.kernel.org/r/20221109-i2c-waive-v2-0-07550bf2dacc@chromium.org Changes in v2: - Cover also device remove - Link to v1: https://lore.kernel.org/r/20221109-i2c-waive-v1-0-ed70a99b990d@chromium.org --- Ricardo Ribalda (1): i2c: Restore initial power state when we are done. drivers/i2c/i2c-core-base.c | 11 +++++++---- include/linux/i2c.h | 4 ++++ 2 files changed, 11 insertions(+), 4 deletions(-) --- base-commit: f141df371335645ce29a87d9683a3f79fba7fd67 change-id: 20221109-i2c-waive-ae97fea1f1b5 Best regards, -- Ricardo Ribalda