From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA726C433FE for ; Wed, 9 Nov 2022 17:12:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231690AbiKIRMh (ORCPT ); Wed, 9 Nov 2022 12:12:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbiKIRM3 (ORCPT ); Wed, 9 Nov 2022 12:12:29 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45FC117882 for ; Wed, 9 Nov 2022 09:12:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D319361B97 for ; Wed, 9 Nov 2022 17:12:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADC3EC433D6; Wed, 9 Nov 2022 17:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668013948; bh=3vd49ukae8zqaQGFhhI5nKYPSFH2xOZx47twfXi5kN0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MrUA3vAVX1cqpe0NlU3gcWXwLZPtJNqcBfXircUxx/pZ2V2iyiFaIkN+NP/UlPdso y1yAYg1NH2zmDhzTHaI7mFFVnvQ8FH1xmEiD1obxY2Roou/RMMPu06QSrbOBjSOQ7R tMuGbLLH5mlFEXot26GhYpacgIOVfcnXMGFHHQfAcNnQr2iGUktjXJuRzngDx6WQ58 9w0VM0WiJCp/mtsaQFcW3jNrwz7VNmHO8NxdO392VVt7woKpflZFvtSt9jlIIG0dUn BAEdAA/IbZj/BFCeBA8iqE2INQokntTw+tZt8OoRwmt1ZRKfMmmAnKNZTFqMQOmygm 9Ot5+4O9Y+BrQ== Date: Wed, 9 Nov 2022 18:12:25 +0100 From: Frederic Weisbecker To: Anna-Maria Behnsen Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel Subject: Re: [PATCH v4 14/16] timer: Implement the hierarchical pull model Message-ID: <20221109171225.GB300561@lothringen> References: <20221104145737.71236-1-anna-maria@linutronix.de> <20221104145737.71236-15-anna-maria@linutronix.de> <20221107220727.GA10939@lothringen> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2022 at 05:16:11PM +0100, Anna-Maria Behnsen wrote: > On Mon, 7 Nov 2022, Frederic Weisbecker wrote: > > > + } > > > + } > > > + > > > /* We need to mark both bases in sync */ > > > base_local->is_idle = base_global->is_idle = is_idle; > > > > Do we still need to maintain base_global->is_idle ? > > is_idle information is required in trigger_dyntick_cpu(). I made a mistake > with the hunk in trigger_dyntick_cpu() introduced in this patch. Because > after this patch, global timers are still enqueued on any CPU because > crystallball still exists. trigger_dyntick_cpu() is also required for non > pinned timers. I need to move the hunk of trigger_dyntick_cpu() into the > last patch of the queue where crystallball is removed during enqueue and > there update also this line. Then I will drop the update of > base_global->is_idle in timer_clear_idle() as well. > > Sorry. This went wrong during splitting and folding the queue back and > forwards... Sure, no problem, just asked because I wanted to be sure I wasn't missing something. I suggest waiting for broader testing after the current batch lands upstream before removing the crystalball :-) > > > (I'm going to do daily reviews on this patch because it's quite dense :) > > Thanks! I try to answer your questions fast. Let me know when you are done > or when you need an updated version for further review :) You have at least one week ahead of you, the time for me to recollect my brain throughout that patch. Indeed no need to repost now, I'll have some more questions for sure. I like the design, so I'm merely just chasing correctness issues and things that might be made clearer. I'm more afraid of what testing will tell wrt. performance and powersaving but, fortunately, the world will scale much better than me to do this :) Thanks! > > Thanks, > > Anna-Maria >