From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Daniel Sneddon <daniel.sneddon@linux.intel.com>,
"antonio.gomez.iglesias@linux.intel.com"
<antonio.gomez.iglesias@linux.intel.com>
Subject: Re: [PATCH 2/3] x86/cpu/amd: Add feature bit for MSR_AMD64_LS_CFG enumeration
Date: Wed, 9 Nov 2022 22:09:03 -0800 [thread overview]
Message-ID: <20221110060903.vud266getvlihxet@desk> (raw)
In-Reply-To: <bee087ff-d7f7-4f6a-4c43-8c91fdec043a@citrix.com>
On Thu, Nov 10, 2022 at 12:00:11AM +0000, Andrew Cooper wrote:
>On 09/11/2022 17:37, Pawan Gupta wrote:
>> If SSBD is the only reason to restore MSR_AMD64_LS_CFG then we should be
>> able to use X86_FEATURE_LS_CFG_SSBD for enumeration.
>
>Yeah, although it occurs to me that you probably don't want to
>save/restore the whole MSR. It's full of other things which want to
>stay in their current configuration.
Upstream currently saves and restores the whole MSR_AMD64_LS_CFG at
suspend/resume.
Is it that the configuration saved at suspend(other than SSBD) will not
be relevant at resume for this MSR? Is there any harm if keep the
current behavior?
next prev parent reply other threads:[~2022-11-10 6:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 23:38 [PATCH 0/3] Check enumeration before MSR save/restore Pawan Gupta
2022-09-12 23:39 ` [PATCH 1/3] x86/tsx: Add feature bit for TSX control MSR support Pawan Gupta
2022-11-08 18:27 ` Dave Hansen
2022-11-08 22:06 ` Pawan Gupta
2022-09-12 23:40 ` [PATCH 2/3] x86/cpu/amd: Add feature bit for MSR_AMD64_LS_CFG enumeration Pawan Gupta
2022-11-08 18:54 ` Borislav Petkov
2022-11-08 22:51 ` Pawan Gupta
2022-11-08 23:10 ` Borislav Petkov
2022-11-09 0:45 ` Andrew Cooper
2022-11-09 17:37 ` Pawan Gupta
2022-11-09 18:34 ` Borislav Petkov
2022-11-09 21:41 ` Pawan Gupta
2022-11-10 0:00 ` Andrew Cooper
2022-11-10 6:09 ` Pawan Gupta [this message]
2022-11-09 2:18 ` Pawan Gupta
2022-09-12 23:41 ` [PATCH 3/3] x86/pm: Add enumeration check before spec MSRs save/restore setup Pawan Gupta
2022-11-08 18:40 ` Dave Hansen
2022-11-08 22:09 ` Pawan Gupta
2022-09-13 0:50 ` [PATCH 0/3] Check enumeration before MSR save/restore Pawan Gupta
2022-09-17 11:42 ` Hans de Goede
2022-09-19 16:56 ` Pawan Gupta
2022-11-08 18:16 ` Hans de Goede
2022-11-08 18:26 ` Borislav Petkov
2022-11-08 18:55 ` Borislav Petkov
2022-11-08 22:07 ` Pawan Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110060903.vud266getvlihxet@desk \
--to=pawan.kumar.gupta@linux.intel.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=antonio.gomez.iglesias@linux.intel.com \
--cc=bp@alien8.de \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).