From: coverity-bot <keescook@chromium.org>
To: Ben Skeggs <bskeggs@redhat.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
Lyude Paul <lyude@redhat.com>, Karol Herbst <kherbst@redhat.com>,
David Airlie <airlied@gmail.com>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
Jani Nikula <jani.nikula@intel.com>,
Dave Airlie <airlied@redhat.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Coverity: nv50_pior_atomic_enable(): Memory - corruptions
Date: Thu, 10 Nov 2022 08:48:48 -0800 [thread overview]
Message-ID: <202211100848.F4C2819BB@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221110 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Wed Nov 9 08:22:02 2022 +1000
813443721331 ("drm/nouveau/disp: move DP link config into acquire")
Coverity reported the following:
*** CID 1527268: Memory - corruptions (OVERRUN)
drivers/gpu/drm/nouveau/dispnv50/disp.c:1817 in nv50_pior_atomic_enable()
1811 case DCB_OUTPUT_TMDS:
1812 ctrl |= NVDEF(NV507D, PIOR_SET_CONTROL, PROTOCOL, EXT_TMDS_ENC);
1813 nvif_outp_acquire_tmds(&nv_encoder->outp, false, false, 0, 0, 0, false);
1814 break;
1815 case DCB_OUTPUT_DP:
1816 ctrl |= NVDEF(NV507D, PIOR_SET_CONTROL, PROTOCOL, EXT_TMDS_ENC);
vvv CID 1527268: Memory - corruptions (OVERRUN)
vvv Overrunning array "(*nv_encoder).dp.dpcd" of 15 bytes by passing it to a function which accesses it at byte offset 15.
1817 nvif_outp_acquire_dp(&nv_encoder->outp, nv_encoder->dp.dpcd, 0, 0, false, false);
1818 break;
1819 default:
1820 BUG();
1821 break;
1822 }
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1527268 ("Memory - corruptions")
Fixes: 813443721331 ("drm/nouveau/disp: move DP link config into acquire")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2022-11-10 16:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211100848.F4C2819BB@keescook \
--to=keescook@chromium.org \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@embeddedor.com \
--cc=jani.nikula@intel.com \
--cc=kherbst@redhat.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).