From: Alexander Lobakin <alexandr.lobakin@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Alexander Lobakin <alexandr.lobakin@intel.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, ast@kernel.org,
daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
linux@armlinux.org.uk, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v3 0/4] net: lan966x: Add xdp support
Date: Thu, 10 Nov 2022 17:21:48 +0100 [thread overview]
Message-ID: <20221110162148.3533816-1-alexandr.lobakin@intel.com> (raw)
In-Reply-To: <Y20DT2XTTIlU/wbx@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Thu, 10 Nov 2022 14:57:35 +0100
> > Nice stuff! I hear time to time that XDP is for 10G+ NICs only, but
> > I'm not a fan of such, and this series proves once again XDP fits
> > any hardware ^.^
>
> The Freescale FEC recently gained XDP support. Many variants of it are
> Fast Ethernet only.
>
> What i found most interesting about that patchset was that the use of
> the page_ppol API made the driver significantly faster for the general
> case as well as XDP.
The driver didn't have any page recycling or page splitting logics,
while Page Pool recycles even pages from skbs if
skb_mark_for_recycle() is used, which is the case here. So it
significantly reduced the number of new page allocations for Rx, if
there still are any at all.
Plus, Page Pool allocates pages by bulks (of 16 IIRC), not one by
one, that reduces CPU overhead as well.
>
> Andrew
Thanks,
Olek
next prev parent reply other threads:[~2022-11-10 16:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 20:46 [PATCH net-next v3 0/4] net: lan966x: Add xdp support Horatiu Vultur
2022-11-09 20:46 ` [PATCH net-next v3 1/4] net: lan966x: Add define IFH_LEN_BYTES Horatiu Vultur
2022-11-09 20:46 ` [PATCH net-next v3 2/4] net: lan966x: Split function lan966x_fdma_rx_get_frame Horatiu Vultur
2022-11-09 20:46 ` [PATCH net-next v3 3/4] net: lan966x: Add basic XDP support Horatiu Vultur
2022-11-09 20:46 ` [PATCH net-next v3 4/4] net: lan96x: Use page_pool API Horatiu Vultur
2022-11-10 11:17 ` [PATCH net-next v3 0/4] net: lan966x: Add xdp support Alexander Lobakin
2022-11-10 13:57 ` Andrew Lunn
2022-11-10 16:21 ` Alexander Lobakin [this message]
2022-11-10 20:21 ` Horatiu Vultur
2022-11-10 22:51 ` Andrew Lunn
2022-11-11 11:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110162148.3533816-1-alexandr.lobakin@intel.com \
--to=alexandr.lobakin@intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).