From: Peter Xu <peterx@redhat.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: peterx@redhat.com, Andrea Arcangeli <aarcange@redhat.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Ives van Hoorne <ives@codesandbox.io>,
Nadav Amit <nadav.amit@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.vnet.ibm.com>
Subject: [PATCH v2 0/2] mm/migrate: Fix writable pte for read migration entry
Date: Thu, 10 Nov 2022 15:31:30 -0500 [thread overview]
Message-ID: <20221110203132.1498183-1-peterx@redhat.com> (raw)
v2:
- Replace WARN_ON_ONCE with VM_WARN_ON_ONCE in patch 2 [Nadav]
This comes from a report from Ives on using uffd-wp on shmem. More
information can be found in patch 1 commit message.
Patch 2 added some more sanity check when walking pgtables and when we
convert the ptes into other forms e.g. for migration and swap. It will
make the error trigger even earlier than the user could notice, meanwhile
nail down the case if it's a wrong pgtable setup.
Ives, I only attached the reported-by tag for you but not tested-by because
the fix patch (patch 1) has a slight change compared to what I sent you
before, but hopefully it should also work for you. If you want, feel free
to reply directly here if the patch also works for you.
We probably need patch 1 for stable (5.19+). Please have a look, thanks.
Peter Xu (2):
mm/migrate: Fix read-only page got writable when recover pte
mm/uffd: Sanity check write bit for uffd-wp protected ptes
arch/x86/include/asm/pgtable.h | 16 +++++++++++++++-
mm/migrate.c | 8 +++++++-
2 files changed, 22 insertions(+), 2 deletions(-)
--
2.37.3
next reply other threads:[~2022-11-10 20:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 20:31 Peter Xu [this message]
2022-11-10 20:31 ` [PATCH v2 1/2] mm/migrate: Fix read-only page got writable when recover pte Peter Xu
2022-11-10 21:28 ` Nadav Amit
2022-11-10 22:09 ` Peter Xu
[not found] ` <CADnc5G2-7B7qyPitDY33Wb0D5a=pq-1PC=gp0f9peTtVnOvzjw@mail.gmail.com>
2022-11-10 22:08 ` Peter Xu
2022-11-10 23:42 ` Alistair Popple
2022-11-13 23:56 ` Peter Xu
2022-11-14 6:22 ` Alistair Popple
2022-11-14 16:09 ` David Hildenbrand
2022-11-14 20:09 ` Peter Xu
2022-11-15 9:13 ` David Hildenbrand
2022-11-15 16:08 ` Peter Xu
2022-11-15 17:22 ` David Hildenbrand
2022-11-15 17:54 ` David Hildenbrand
2022-11-15 18:11 ` Peter Xu
2022-11-15 18:16 ` David Hildenbrand
2022-11-15 18:03 ` Peter Xu
2022-11-15 18:08 ` David Hildenbrand
2022-11-10 20:31 ` [PATCH v2 2/2] mm/uffd: Sanity check write bit for uffd-wp protected ptes Peter Xu
2022-11-11 22:06 ` kernel test robot
2022-11-13 22:33 ` Peter Xu
2022-11-12 2:59 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110203132.1498183-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=ives@codesandbox.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nadav.amit@gmail.com \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).