From: Paul Gazzillo <paul@pgazz.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Shreeya Patel <shreeya.patel@collabora.com>,
Zhigang Shi <Zhigang.Shi@liteon.com>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1]: iio: light: rpr0521: add missing Kconfig dependencies
Date: Thu, 10 Nov 2022 15:43:22 -0500 [thread overview]
Message-ID: <20221110204322.waygj3v466haadmr@device> (raw)
In-Reply-To: <Y20b8Ty71+qk8aDZ@smile.fi.intel.com>
On 11/10/2022, Andy Shevchenko wrote:
> On Thu, Nov 10, 2022 at 09:44:48AM -0500, Paul Gazzillo wrote:
>
> > CC drivers/iio/light/rpr0521.o
> > drivers/iio/light/rpr0521.c: In function 'rpr0521_drdy_irq_thread':
>
> These two lines can be removed.
Will do.
> > (This bug was found with the help of a tool, krepair, that generates
> > configuration files for commits: https://github.com/paulgazz/kmax)
>
> I'm not sure we need this in the commit message. Do we have a tag for
> the static analyzers?
I'll also remove this.
> > The following patch ensures that the code controlled by IIO_BUFFER and
> > IIO_TRIGGERED_BUFFER is available:
>
> > Reported-by: Paul Gazzillo <paul@pgazz.com>
>
> Without SoB this may not be anyhow proceeded. Please, read Submitting Patches
> documentation and try again.
>
> (Btw, Reported-by above contradicts the commit message that refers to the tool,
> and not human)
Apologies, I was confused about whether I or the maintainer fills that
out. Will submit a new version with SoB.
Thanks!
Paul
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2022-11-10 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 14:44 [PATCH v1 1/1]: iio: light: rpr0521: add missing Kconfig dependencies Paul Gazzillo
2022-11-10 15:42 ` Andy Shevchenko
2022-11-10 20:43 ` Paul Gazzillo [this message]
2022-11-10 21:47 ` [PATCH v2 " Paul Gazzillo
2022-11-11 11:25 ` Andy Shevchenko
2022-11-11 15:25 ` Paul Gazzillo
2022-11-12 17:37 ` Jonathan Cameron
2022-11-14 16:22 ` Paul Gazzillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110204322.waygj3v466haadmr@device \
--to=paul@pgazz.com \
--cc=Zhigang.Shi@liteon.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.osipenko@collabora.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).