From: Wang ShaoBo <bobo.shaobowang@huawei.com>
To: unlisted-recipients:; (no To-header on input)
Cc: <rafael.j.wysocki@intel.com>, <rafael@kernel.org>,
<lenb@kernel.org>, <yu.c.chen@intel.com>,
<linux-acpi@vger.kernel.org>, <guohanjun@huawei.com>,
<liwei391@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] ACPI: pfr_update: use ACPI_FREE() to free acpi_object
Date: Fri, 18 Nov 2022 14:32:19 +0800 [thread overview]
Message-ID: <20221118063219.2612473-3-bobo.shaobowang@huawei.com> (raw)
In-Reply-To: <20221118063219.2612473-1-bobo.shaobowang@huawei.com>
acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled with
ACPI_FREE() to free the ACPI memory, because we need to track the
allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS enabled,
so use ACPI_FREE() instead of kfree().
Fixes: 0db89fa243e5 ("ACPI: Introduce Platform Firmware Runtime Update device driver")
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---
drivers/acpi/pfr_update.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/pfr_update.c b/drivers/acpi/pfr_update.c
index 6bb0b778b5da..9d2bdc13253a 100644
--- a/drivers/acpi/pfr_update.c
+++ b/drivers/acpi/pfr_update.c
@@ -178,7 +178,7 @@ static int query_capability(struct pfru_update_cap_info *cap_hdr,
ret = 0;
free_acpi_buffer:
- kfree(out_obj);
+ ACPI_FREE(out_obj);
return ret;
}
@@ -224,7 +224,7 @@ static int query_buffer(struct pfru_com_buf_info *info,
ret = 0;
free_acpi_buffer:
- kfree(out_obj);
+ ACPI_FREE(out_obj);
return ret;
}
@@ -385,7 +385,7 @@ static int start_update(int action, struct pfru_device *pfru_dev)
ret = 0;
free_acpi_buffer:
- kfree(out_obj);
+ ACPI_FREE(out_obj);
return ret;
}
--
2.25.1
next prev parent reply other threads:[~2022-11-18 6:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 6:32 [PATCH 0/2] change to use ACPI_FREE() to free the ACPI memory Wang ShaoBo
2022-11-18 6:32 ` [PATCH 1/2] ACPI: pfr_telemetry: use ACPI_FREE() to free acpi_object Wang ShaoBo
2022-11-18 11:21 ` Chen Yu
2022-11-18 6:32 ` Wang ShaoBo [this message]
2022-11-18 11:23 ` [PATCH 2/2] ACPI: pfr_update: " Chen Yu
2022-11-23 18:30 ` [PATCH 0/2] change to use ACPI_FREE() to free the ACPI memory Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221118063219.2612473-3-bobo.shaobowang@huawei.com \
--to=bobo.shaobowang@huawei.com \
--cc=guohanjun@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).