From: "Paul E. McKenney" <paulmck@kernel.org>
To: Zhouyi Zhou <zhouzhouyi@gmail.com>
Cc: fweisbec@gmail.com, tglx@linutronix.de, mingo@kernel.org,
dave@stgolabs.net, josh@joshtriplett.org, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next][RFC]torture: avoid offline tick_do_timer_cpu
Date: Mon, 21 Nov 2022 17:37:54 -0800 [thread overview]
Message-ID: <20221122013754.GY4001@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <20221121035140.118651-1-zhouzhouyi@gmail.com>
On Mon, Nov 21, 2022 at 11:51:40AM +0800, Zhouyi Zhou wrote:
> During CPU-hotplug torture (CONFIG_NO_HZ_FULL=y), if we try to
> offline tick_do_timer_cpu, the operation will fail because in
> function tick_nohz_cpu_down:
> ```
> if (tick_nohz_full_running && tick_do_timer_cpu == cpu)
> return -EBUSY;
> ```
> Above bug was first discovered in torture tests performed in PPC VM
> of Open Source Lab of Oregon State University, and reproducable in RISC-V
> and X86-64 (with additional kernel commandline cpu0_hotplug).
>
> In this patch, we avoid offline tick_do_timer_cpu by distribute
> the offlining cpu among remaining cpus.
>
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
Good show chasing this down!
A couple of questions below.
> ---
> include/linux/tick.h | 1 +
> kernel/time/tick-common.c | 1 +
> kernel/time/tick-internal.h | 1 -
> kernel/torture.c | 10 ++++++++++
> 4 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/tick.h b/include/linux/tick.h
> index bfd571f18cfd..23cc0b205853 100644
> --- a/include/linux/tick.h
> +++ b/include/linux/tick.h
> @@ -14,6 +14,7 @@
> #include <linux/rcupdate.h>
>
> #ifdef CONFIG_GENERIC_CLOCKEVENTS
> +extern int tick_do_timer_cpu __read_mostly;
> extern void __init tick_init(void);
> /* Should be core only, but ARM BL switcher requires it */
> extern void tick_suspend_local(void);
> diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
> index 46789356f856..87b9b9afa320 100644
> --- a/kernel/time/tick-common.c
> +++ b/kernel/time/tick-common.c
> @@ -48,6 +48,7 @@ ktime_t tick_next_period;
> * procedure also covers cpu hotplug.
> */
> int tick_do_timer_cpu __read_mostly = TICK_DO_TIMER_BOOT;
> +EXPORT_SYMBOL_GPL(tick_do_timer_cpu);
> #ifdef CONFIG_NO_HZ_FULL
> /*
> * tick_do_timer_boot_cpu indicates the boot CPU temporarily owns
> diff --git a/kernel/time/tick-internal.h b/kernel/time/tick-internal.h
> index 649f2b48e8f0..8953dca10fdd 100644
> --- a/kernel/time/tick-internal.h
> +++ b/kernel/time/tick-internal.h
> @@ -15,7 +15,6 @@
>
> DECLARE_PER_CPU(struct tick_device, tick_cpu_device);
> extern ktime_t tick_next_period;
> -extern int tick_do_timer_cpu __read_mostly;
>
> extern void tick_setup_periodic(struct clock_event_device *dev, int broadcast);
> extern void tick_handle_periodic(struct clock_event_device *dev);
> diff --git a/kernel/torture.c b/kernel/torture.c
> index 789aeb0e1159..bccbdd33dda2 100644
> --- a/kernel/torture.c
> +++ b/kernel/torture.c
> @@ -33,6 +33,7 @@
> #include <linux/delay.h>
> #include <linux/stat.h>
> #include <linux/slab.h>
> +#include <linux/tick.h>
> #include <linux/trace_clock.h>
> #include <linux/ktime.h>
> #include <asm/byteorder.h>
> @@ -358,7 +359,16 @@ torture_onoff(void *arg)
> schedule_timeout_interruptible(HZ / 10);
> continue;
> }
> +#ifdef CONFIG_NO_HZ_FULL
> + /* do not offline tick do timer cpu */
> + if (tick_nohz_full_running) {
> + cpu = (torture_random(&rand) >> 4) % maxcpu;
> + if (cpu >= tick_do_timer_cpu)
Why is this ">=" instead of "=="?
> + cpu = (cpu + 1) % (maxcpu + 1);
> + } else
> +#else
> cpu = (torture_random(&rand) >> 4) % (maxcpu + 1);
> +#endif
What happens if the value of tick_do_timer_cpu changes between the time of
the check above and the call to torture_offline() below? Alternatively,
how is such a change in value prevented?
Thanx, Paul
> if (!torture_offline(cpu,
> &n_offline_attempts, &n_offline_successes,
> &sum_offline, &min_offline, &max_offline))
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-11-22 1:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 3:51 [PATCH linux-next][RFC]torture: avoid offline tick_do_timer_cpu Zhouyi Zhou
2022-11-22 1:37 ` Paul E. McKenney [this message]
2022-11-23 2:23 ` Zhouyi Zhou
2022-11-23 18:49 ` Paul E. McKenney
2022-11-24 2:35 ` Zhouyi Zhou
2022-11-23 22:25 ` Frederic Weisbecker
2022-11-23 23:00 ` Paul E. McKenney
2022-11-23 22:36 ` Frederic Weisbecker
2022-11-24 2:18 ` Zhouyi Zhou
2022-11-26 17:05 ` Thomas Gleixner
2022-11-27 2:45 ` Zhouyi Zhou
2022-11-27 12:40 ` Thomas Gleixner
2022-11-27 17:53 ` Paul E. McKenney
2022-11-28 3:00 ` Zhouyi Zhou
2022-11-28 8:12 ` Thomas Gleixner
2022-11-28 15:16 ` Paul E. McKenney
2023-07-06 7:09 ` Christophe Leroy
2023-07-06 8:13 ` Zhouyi Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122013754.GY4001@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=dave@stgolabs.net \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=tglx@linutronix.de \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).