From: Josh Poimboeuf <jpoimboe@kernel.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
sfr@canb.auug.org.au, linux-kernel@vger.kernel.org
Subject: Re: objtool warning for next-20221118
Date: Mon, 21 Nov 2022 21:16:05 -0800 [thread overview]
Message-ID: <20221122051605.4hcbslwxez2trdvt@treble> (raw)
In-Reply-To: <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1>
On Mon, Nov 21, 2022 at 06:52:15AM -0800, Paul E. McKenney wrote:
> On Mon, Nov 21, 2022 at 12:31:57PM +0100, Peter Zijlstra wrote:
> > On Sun, Nov 20, 2022 at 08:07:36PM -0800, Paul E. McKenney wrote:
> > > Hello!
> > >
> > > I have started getting this from rcutorture scenario TREE09:
> > >
> > > vmlinux.o: warning: objtool: do_idle+0x25f: unreachable instruction
> > >
> > > Should I be worried?
> >
> > Typically not a scary warning that.
> >
> > > If so, please let me know what additional information you need.
> >
> > .config and compiler version so that I might recreate and observe what
> > it's complaining about would help :-)
>
> Fair enough! ;-)
>
> .config is attached, and the compiler versions are:
>
> gcc version 8.5.0 20210514 (Red Hat 8.5.0-15) (GCC)
> gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)
>
> From an RCU perspective, the key points about TREE09's .config is
> CONFIG_PREEMPTION=y and CONFIG_SMP=n, but running on a single-CPU qemu
> instance.
It's complaining about an unreachable instruction after a call to
arch_cpu_idle_dead(). In this case objtool detects the fact
arch_cpu_idle_dead() doesn't return due to its call to the
non-CONFIG_SMP version of play_dead(). But GCC has no way of detecting
that because the caller is in another translation unit.
As far as I can tell, that function should never return. Though it
seems to have some dubious semantics (see xen_pv_play_dead() for
example, which *does* seem to return?). I'm thinking it would be an
improvement to enforce that noreturn behavior across all arches and
platforms, sprinkling __noreturn and BUG() on arch_cpu_idle_dead() and
maybe some of it callees, where needed.
Peter, what do you think? I could attempt a patch.
--
Josh
next prev parent reply other threads:[~2022-11-22 5:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 4:07 objtool warning for next-20221118 Paul E. McKenney
2022-11-21 11:31 ` Peter Zijlstra
2022-11-21 14:52 ` Paul E. McKenney
2022-11-22 5:16 ` Josh Poimboeuf [this message]
2022-11-22 8:35 ` Peter Zijlstra
2022-11-23 0:22 ` Paul E. McKenney
2022-11-23 1:48 ` Josh Poimboeuf
2022-11-23 17:49 ` Paul E. McKenney
2022-11-23 18:19 ` Josh Poimboeuf
2022-11-23 19:12 ` Paul E. McKenney
2022-11-23 22:32 ` Josh Poimboeuf
2022-11-23 23:06 ` Paul E. McKenney
2023-01-28 19:06 ` Paul E. McKenney
2023-02-01 0:02 ` Josh Poimboeuf
2023-02-01 0:33 ` Paul E. McKenney
2023-02-01 4:21 ` Paul E. McKenney
2022-11-23 1:23 ` Josh Poimboeuf
2022-11-23 8:55 ` Peter Zijlstra
2022-11-23 10:52 ` Andrew Cooper
2022-11-23 17:03 ` Josh Poimboeuf
2022-11-24 2:39 ` Josh Poimboeuf
2022-11-24 5:28 ` Juergen Gross
2022-11-24 7:47 ` Juergen Gross
2022-11-24 16:39 ` Josh Poimboeuf
2022-11-25 5:30 ` Juergen Gross
2022-11-29 19:56 ` Paul E. McKenney
2022-12-02 0:27 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122051605.4hcbslwxez2trdvt@treble \
--to=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).