From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41EF9C43219 for ; Tue, 22 Nov 2022 22:45:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234896AbiKVWpP (ORCPT ); Tue, 22 Nov 2022 17:45:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232517AbiKVWpN (ORCPT ); Tue, 22 Nov 2022 17:45:13 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAF53BEB5E; Tue, 22 Nov 2022 14:45:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8F10EB81DEC; Tue, 22 Nov 2022 22:45:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6C55C433B5; Tue, 22 Nov 2022 22:45:07 +0000 (UTC) Date: Tue, 22 Nov 2022 17:45:06 -0500 From: Steven Rostedt To: David Laight Cc: 'Thomas Gleixner' , LKML , Linus Torvalds , Anna-Maria Behnsen , "Peter Zijlstra" , Stephen Boyd , "Guenter Roeck" , Andrew Morton , "Julia Lawall" , Arnd Bergmann , Viresh Kumar , Marc Zyngier , Marcel Holtmann , Johan Hedberg , "Luiz Augusto von Dentz" , "linux-bluetooth@vger.kernel.org" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" , "netdev@vger.kernel.org" Subject: Re: [patch V2 09/17] timers: Rename del_timer_sync() to timer_delete_sync() Message-ID: <20221122174506.08ce49bd@gandalf.local.home> In-Reply-To: <2c42cb1fe1fa4b11ba3c0263d7886b68@AcuMS.aculab.com> References: <20221122171312.191765396@linutronix.de> <20221122173648.619071341@linutronix.de> <2c42cb1fe1fa4b11ba3c0263d7886b68@AcuMS.aculab.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Nov 2022 22:23:11 +0000 David Laight wrote: > > Rename del_timer_sync() to timer_delete_sync() and provide del_timer_sync() > > as a wrapper. Document that del_timer_sync() is not for new code. > > To change the colo[u]r of the bikeshed, would it be better to > name the functions timer_start() and timer_stop[_sync](). I kinda like this color. ;-) -- Steve