Re: [PATCH v6 6/6] zsmalloc: Implement writeback mechanism for zsmalloc

From: Nhat Pham <nphamcs@gmail.com>
To: senozhatsky@chromium.org
Cc: hannes@cmpxchg.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, minchan@kernel.org,
	ngupta@vflare.org, akpm@linux-foundation.org,
	sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com
Subject: Re: [PATCH v6 6/6] zsmalloc: Implement writeback mechanism for zsmalloc
Date: Wed, 23 Nov 2022 08:30:44 -0800	[thread overview]
Message-ID: <20221123163044.2029016-1-nphamcs@gmail.com> (raw)
In-Reply-To: <Y3xuKXmNjs87q3AW@google.com>

Thanks for the comments, Sergey!

> A nit: we usually call get_first_page() in such cases.

I'll use get_first_page() here in v7.

> We probably better to cond_resched() somewhere here. Or in zs_zpool_shrink()
> loop.

I'll put it right after releasing the pool's lock in the retry loop:

		/* Lock out object allocations and object compaction */
		remove_zspage(class, zspage, fullness);

		spin_unlock(&pool->lock);
		cond_resched();

		/* Lock backing pages into place */
		lock_zspage(zspage);

This will also appear in v7. In the meantime, please feel free to discuss all
the patches - I'll try to batch the changes to minimize the churning.