From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B81C433FE for ; Thu, 24 Nov 2022 08:12:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229869AbiKXIMY (ORCPT ); Thu, 24 Nov 2022 03:12:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229837AbiKXILv (ORCPT ); Thu, 24 Nov 2022 03:11:51 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 316E1DDFB5 for ; Thu, 24 Nov 2022 00:11:30 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id i10so2435026ejg.6 for ; Thu, 24 Nov 2022 00:11:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6YHJgPorhOUbyl8qXKZ/Y1Fb0whHUGXa2Cr+bH3NpKM=; b=B4nBu20bW7mnUL2BeHRcg59KXuEcGTlAVaR5iapLDCicXnF3jFRGL0KaCd3/+h9Tdw vY9pRcqoKoWybtisYS+ZxcgaQKr5iVDQ7zAsYRhTzvbjh9N+7LqU/5PuYXAq73/SPu5K lK1a6zcpRASRjG7B8xKq1P1Np87iRH6szFwH0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6YHJgPorhOUbyl8qXKZ/Y1Fb0whHUGXa2Cr+bH3NpKM=; b=EeVjT+WyESgSeqMQ5ybrrak1zTsFYDR4xeMDh9AMnVsqMFXtn7yNFyIdn1qaaLkNTZ Vf4JG/8TZjtUr2Pu4rEh6h/ACUwY8nKDZvsYdOI9NYKoTQctzxEBD5gGdNC1CK6lZi0y 4kqZ3SpZM/nLQye+VrdEtPMfPhd04UDVbDgP+HS8QayfAnYzvu2KfmYwzfFDZriiZ9y9 wLycKP+4eUUPtvV/c8C6XQ5bapmwCs8KIcS5RGko2nCiHUQ4RLMc8EQssF5BwQfwR2Se Ux5WLcUTitiED3ToyVTdt/kKdK+5YJfE6QOUuFXTgq2EixQ+sh/OK7hZIIqIiNb1HBHK J6ig== X-Gm-Message-State: ANoB5pml9Fi7cMztivTv0k2ILPGs37yhMu6pZ3arqH3KhOyUIQSmm6m9 dZNgNlOa/+B2+IPCyYXYBgOO4Q== X-Google-Smtp-Source: AA0mqf7aVZbVSFuG+L8Eyzm7AhG74w3bgdJjvzEEZlZQFKaZUtPxj3jnE/eIs0+1qpSwdBYG5TXoFA== X-Received: by 2002:a17:906:245a:b0:78d:857d:b4a8 with SMTP id a26-20020a170906245a00b0078d857db4a8mr5069511ejb.495.1669277488639; Thu, 24 Nov 2022 00:11:28 -0800 (PST) Received: from tom-ThinkPad-T14s-Gen-2i (net-188-217-55-94.cust.vodafonedsl.it. [188.217.55.94]) by smtp.gmail.com with ESMTPSA id wl3-20020a170907310300b007b4bc423b41sm145907ejb.190.2022.11.24.00.11.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 00:11:27 -0800 (PST) Date: Thu, 24 Nov 2022 09:11:26 +0100 From: Tommaso Merciai To: "T.J. Mercier" Cc: Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma-buf: A collection of typo and documentation fixes Message-ID: <20221124081126.GA607444@tom-ThinkPad-T14s-Gen-2i> References: <20221123193519.3948105-1-tjmercier@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123193519.3948105-1-tjmercier@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi T.J, On Wed, Nov 23, 2022 at 07:35:18PM +0000, T.J. Mercier wrote: > I've been collecting these typo fixes for a while and it feels like > time to send them in. > > Signed-off-by: T.J. Mercier > --- > drivers/dma-buf/dma-buf.c | 14 +++++++------- > include/linux/dma-buf.h | 6 +++--- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index dd0f83ee505b..614ccd208af4 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -1141,7 +1141,7 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_unmap_attachment, DMA_BUF); > * > * @dmabuf: [in] buffer which is moving > * > - * Informs all attachmenst that they need to destroy and recreated all their > + * Informs all attachments that they need to destroy and recreate all their > * mappings. > */ > void dma_buf_move_notify(struct dma_buf *dmabuf) > @@ -1159,11 +1159,11 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_move_notify, DMA_BUF); > /** > * DOC: cpu access > * > - * There are mutliple reasons for supporting CPU access to a dma buffer object: > + * There are multiple reasons for supporting CPU access to a dma buffer object: > * > * - Fallback operations in the kernel, for example when a device is connected > * over USB and the kernel needs to shuffle the data around first before > - * sending it away. Cache coherency is handled by braketing any transactions > + * sending it away. Cache coherency is handled by bracketing any transactions > * with calls to dma_buf_begin_cpu_access() and dma_buf_end_cpu_access() > * access. > * > @@ -1190,7 +1190,7 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_move_notify, DMA_BUF); > * replace ION buffers mmap support was needed. > * > * There is no special interfaces, userspace simply calls mmap on the dma-buf > - * fd. But like for CPU access there's a need to braket the actual access, > + * fd. But like for CPU access there's a need to bracket the actual access, > * which is handled by the ioctl (DMA_BUF_IOCTL_SYNC). Note that > * DMA_BUF_IOCTL_SYNC can fail with -EAGAIN or -EINTR, in which case it must > * be restarted. > @@ -1264,10 +1264,10 @@ static int __dma_buf_begin_cpu_access(struct dma_buf *dmabuf, > * preparations. Coherency is only guaranteed in the specified range for the > * specified access direction. > * @dmabuf: [in] buffer to prepare cpu access for. > - * @direction: [in] length of range for cpu access. > + * @direction: [in] direction of access. > * > * After the cpu access is complete the caller should call > - * dma_buf_end_cpu_access(). Only when cpu access is braketed by both calls is > + * dma_buf_end_cpu_access(). Only when cpu access is bracketed by both calls is > * it guaranteed to be coherent with other DMA access. > * > * This function will also wait for any DMA transactions tracked through > @@ -1307,7 +1307,7 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_begin_cpu_access, DMA_BUF); > * actions. Coherency is only guaranteed in the specified range for the > * specified access direction. > * @dmabuf: [in] buffer to complete cpu access for. > - * @direction: [in] length of range for cpu access. > + * @direction: [in] direction of access. > * > * This terminates CPU access started with dma_buf_begin_cpu_access(). > * > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h > index 71731796c8c3..1d61a4f6db35 100644 > --- a/include/linux/dma-buf.h > +++ b/include/linux/dma-buf.h > @@ -330,7 +330,7 @@ struct dma_buf { > * @lock: > * > * Used internally to serialize list manipulation, attach/detach and > - * vmap/unmap. Note that in many cases this is superseeded by > + * vmap/unmap. Note that in many cases this is superseded by > * dma_resv_lock() on @resv. > */ > struct mutex lock; > @@ -365,7 +365,7 @@ struct dma_buf { > */ > const char *name; > > - /** @name_lock: Spinlock to protect name acces for read access. */ > + /** @name_lock: Spinlock to protect name access for read access. */ > spinlock_t name_lock; > > /** > @@ -402,7 +402,7 @@ struct dma_buf { > * anything the userspace API considers write access. > * > * - Drivers may just always add a write fence, since that only > - * causes unecessarily synchronization, but no correctness issues. > + * causes unnecessary synchronization, but no correctness issues. > * > * - Some drivers only expose a synchronous userspace API with no > * pipelining across drivers. These do not set any fences for their > -- > 2.38.1.584.g0f3c55d4c2-goog > Looks good to me. Reviewed-by: Tommaso Merciai Thanks & Regards, Tommaso -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com