Hi, On Fri, Nov 25, 2022 at 11:10:02AM -0300, Maíra Canal wrote: > On 11/23/22 12:25, Maxime Ripard wrote: > > The name doesn't really fit the conventions for the other helpers in > > DRM/KMS, so let's rename it to make it obvious that we allocate a new > > DRM device. > > > > Signed-off-by: Maxime Ripard > > Although I believe using "drm_device" on the function name is a bit > redundant (maybe drm_kunit_helper_alloc_dev or drm_kunit_helper_alloc_device > would be cleaner), Yeah, I don't quite like the name either, but we'll need to also allocate a struct device in the next few patches so we need to make the distinction between a struct drm_device and a struct device. Maxime