From: "Pali Rohár" <pali@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linus.walleij@linaro.org, brgl@bgdev.pl,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
lee.jones@linaro.org, andrew@lunn.ch,
thomas.petazzoni@free-electrons.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: gpio: gpio-mvebu: deprecate armadaxp-gpio
Date: Mon, 28 Nov 2022 08:59:59 +0100 [thread overview]
Message-ID: <20221128075959.3a3io5nhaizm7uxj@pali> (raw)
In-Reply-To: <20220526012946.3862776-3-chris.packham@alliedtelesis.co.nz>
On Thursday 26 May 2022 13:29:45 Chris Packham wrote:
> Commit 5f79c651e81e ("arm: mvebu: use global interrupts for GPIOs on
> Armada XP") the marvell,armadaxp-gpio compatible obsolete.
No, marvell,armadaxp-gpio is required for per-cpu interrupt support. I fixed it recently:
https://lore.kernel.org/linux-devicetree/20220714115515.5748-2-pali@kernel.org/
https://lore.kernel.org/linux-devicetree/20220714183328.4137-3-pali@kernel.org/
> The driver code still exists to handle the armadaxp behaviour but all
> the in-tree boards use the marvell,armada-370-gpio. Document the
> marvell,armadaxp-gpio compatible as deprecated.
For per-cpu interrupt support is marvell,armadaxp-gpio needed and
therefore it cannot be deprecated.
What can be deprecated is marvell,armada-370-gpio and it can be replaced
by marvell,orion-gpio, which covers _all_ SoCs starting from the oldest
one = Orion. See discussion for more details:
https://lore.kernel.org/linux-devicetree/20220725200417.nwthxzvdv2bzd5ej@pengutronix.de/
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> Notes:
> This could potentially be squashed into the first commit but it seemed
> more proper to do a straight 1:1 conversion of the old binding then
> clean things up to match reality.
>
> Changes in v4:
> - New
>
> .../devicetree/bindings/gpio/gpio-mvebu.yaml | 24 +++++++------------
> 1 file changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-mvebu.yaml b/Documentation/devicetree/bindings/gpio/gpio-mvebu.yaml
> index d1695e7bd825..459ec35864fe 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-mvebu.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-mvebu.yaml
> @@ -21,17 +21,21 @@ properties:
> - enum:
> - marvell,mv78200-gpio
> - marvell,armada-370-gpio
> - - marvell,armadaxp-gpio
> - const: marvell,orion-gpio
>
> + - description: Deprecated binding
> + items:
> + - const: marvell,armadaxp-gpio
> + - const: marvell,orion-gpio
> + deprecated: true
> +
> reg:
> description: |
> Address and length of the register set for the device. Not used for
> marvell,armada-8k-gpio.
>
> - For the "marvell,armadaxp-gpio" variant a second entry is expected for
> - the per-cpu registers. For other variants second entry can be provided,
> - for the PWM function using the GPIO Blink Counter on/off registers.
> + A second entry can be provided, for the PWM function using the GPIO Blink
> + Counter on/off registers.
> minItems: 1
> maxItems: 2
>
> @@ -103,18 +107,6 @@ allOf:
> required:
> - reg
>
> - - if:
> - properties:
> - compatible:
> - contains:
> - const: marvell,armadaxp-gpio
> - then:
> - properties:
> - reg:
> - minItems: 2
> - reg-names:
> - minItems: 2
> -
> unevaluatedProperties: true
>
> examples:
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-11-28 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 1:29 [PATCH v4 0/3] dt-bindings: gpio: gpio-mvebu: Convert to DT schema format Chris Packham
2022-05-26 1:29 ` [PATCH v4 1/3] dt-bindings: gpio: gpio-mvebu: convert txt binding " Chris Packham
2022-05-26 12:26 ` Krzysztof Kozlowski
2022-05-26 1:29 ` [PATCH v4 2/3] dt-bindings: gpio: gpio-mvebu: deprecate armadaxp-gpio Chris Packham
2022-05-26 12:27 ` Krzysztof Kozlowski
2022-11-28 7:59 ` Pali Rohár [this message]
2022-11-28 20:16 ` Chris Packham
2022-05-26 1:29 ` [PATCH v4 3/3] dt-bindings: gpio: gpio-mvebu: document offset and marvell,pwm-offset Chris Packham
2022-06-19 20:13 ` Uwe Kleine-König
2022-06-22 13:54 ` Thierry Reding
2022-06-23 20:25 ` [PATCH v4 0/3] dt-bindings: gpio: gpio-mvebu: Convert to DT schema format Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128075959.3a3io5nhaizm7uxj@pali \
--to=pali@kernel.org \
--cc=andrew@lunn.ch \
--cc=brgl@bgdev.pl \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).