From: Jan Kara <jack@suse.cz>
To: Rong Tao <rtoax@foxmail.com>
Cc: jack@suse.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, Rong Tao <rongtao@cestc.cn>
Subject: Re: [PATCH] fs/ext2: Fix code indentation
Date: Mon, 28 Nov 2022 11:17:59 +0100 [thread overview]
Message-ID: <20221128101759.cqrvwncfeqracaqk@quack3> (raw)
In-Reply-To: <tencent_EEC5C049082D4BF0724AC5E9956BD41E5105@qq.com>
On Fri 25-11-22 21:38:21, Rong Tao wrote:
> From: Rong Tao <rongtao@cestc.cn>
>
> ts=4 can cause misunderstanding in code reading. It is better to replace
> 8 spaces with one tab.
>
> Signed-off-by: Rong Tao <rongtao@cestc.cn>
Thanks for the cleanup! When doing whitespace cleanup like this, can you
please also fix another 5 lines in fs/ext2/balloc.c which have this problem
and submit it as a single patch together with this? Thanks!
Honza
> ---
> fs/ext2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 03f2af98b1b4..69c88facfe90 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1648,7 +1648,7 @@ static int __init init_ext2_fs(void)
> err = init_inodecache();
> if (err)
> return err;
> - err = register_filesystem(&ext2_fs_type);
> + err = register_filesystem(&ext2_fs_type);
> if (err)
> goto out;
> return 0;
> --
> 2.31.1
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2022-11-28 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 13:38 [PATCH] fs/ext2: Fix code indentation Rong Tao
2022-11-28 10:17 ` Jan Kara [this message]
2022-11-28 12:16 ` Rong Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128101759.cqrvwncfeqracaqk@quack3 \
--to=jack@suse.cz \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rongtao@cestc.cn \
--cc=rtoax@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).