From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Li Huafei <lihuafei1@huawei.com>, <naveen.n.rao@linux.ibm.com>,
<anil.s.keshavamurthy@intel.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kprobes: Fix check for probe enabled in kill_kprobe()
Date: Mon, 28 Nov 2022 14:21:23 -0500 [thread overview]
Message-ID: <20221128142123.5b5570bc@gandalf.local.home> (raw)
In-Reply-To: <20221128174843.244d5485156daf53b6406482@kernel.org>
On Mon, 28 Nov 2022 17:48:43 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> On Sat, 26 Nov 2022 19:43:16 +0800
> Li Huafei <lihuafei1@huawei.com> wrote:
>
> > In kill_kprobe(), the check whether disarm_kprobe_ftrace() needs to be
> > called always fails. This is because before that we set the
> > KPROBE_FLAG_GONE flag for kprobe so that "!kprobe_disabled(p)" is always
> > false.
>
> Good catch!
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Thank you!
Looks good.
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
prev parent reply other threads:[~2022-11-28 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 11:43 [PATCH] kprobes: Fix check for probe enabled in kill_kprobe() Li Huafei
2022-11-28 8:48 ` Masami Hiramatsu
2022-11-28 19:21 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128142123.5b5570bc@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=lihuafei1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).