From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Borislav Petkov <bp@alien8.de>
Cc: bjorn.andersson@linaro.org, mchehab@kernel.org,
james.morse@arm.com, rric@kernel.org,
linux-arm-msm@vger.kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_saipraka@quicinc.com
Subject: Re: [PATCH v4 1/2] EDAC/qcom: Get rid of hardcoded register offsets
Date: Tue, 29 Nov 2022 11:23:51 +0530 [thread overview]
Message-ID: <20221129055351.GA4931@workstation> (raw)
In-Reply-To: <Y4T/YlDdDk7gVdfB@zn.tnic>
On Mon, Nov 28, 2022 at 07:35:14PM +0100, Borislav Petkov wrote:
> On Mon, Nov 28, 2022 at 11:47:05PM +0530, Manivannan Sadhasivam wrote:
> > Well, yes but that would imply both LLCC and EDAC patches going together.
> > Splitting them will break the build, which is worse.
>
> Sounds like you need to check out:
>
> Documentation/process/stable-kernel-rules.rst
>
> first.
>
> Hint: there are provisions in there how to specify dependencies between
> commits.
>
Hmm, I did miss reading this. Thanks for pointing out.
> > Sorry, it is because I only tried building for ARM64 architecture. The
> > error you are seeing is for x86-64 and I could now reproduce it as
> > well.
>
> Yes, because arch doesn't matter here - the .config does.
>
Well, arch does matter here. LLCC driver depends on ARCH_QCOM ||
COMPILE_TEST. In the case of ARCH_QCOM, the REGMAP_MMIO is implicitly
selected and you won't see the error with built-in or as a module.
Only if you unselect ARCH_QCOM and use x86_64 (or any other arch) with
COMPILE_TEST, then you'll see the error with both built-in and module.
> Therefore, as requested:
>
> "For the next version, you'd need to fix all possible Kconfig build
> errors before sending."
>
Sure.
Thanks,
Mani
> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-11-29 5:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 14:33 [PATCH v4 0/2] Fix crash when using Qcom LLCC/EDAC drivers Manivannan Sadhasivam
2022-11-16 14:33 ` [PATCH v4 1/2] EDAC/qcom: Get rid of hardcoded register offsets Manivannan Sadhasivam
2022-11-28 12:16 ` Borislav Petkov
2022-11-28 18:17 ` Manivannan Sadhasivam
2022-11-28 18:35 ` Borislav Petkov
2022-11-29 5:53 ` Manivannan Sadhasivam [this message]
2022-11-16 14:33 ` [PATCH v4 2/2] EDAC/qcom: Remove extra error no assignment in qcom_llcc_core_setup() Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221129055351.GA4931@workstation \
--to=manivannan.sadhasivam@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_saipraka@quicinc.com \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).