linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: iommu@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Will Deacon <will@kernel.org>, Yi Liu <yi.l.liu@intel.com>,
	"Tian, Kevin" <kevin.tian@intel.com>,
	Raj Ashok <ashok.raj@intel.com>,
	Yuzhang Luo <yuzhang.luo@intel.com>,
	jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v2] iommu/vt-d: Add a fix for devices need extra dtlb flush
Date: Tue, 29 Nov 2022 16:34:12 -0800	[thread overview]
Message-ID: <20221129163412.15da3081@jacob-builder> (raw)
In-Reply-To: <9fd4bf6c-5525-c209-28b6-492558c1dd35@linux.intel.com>

Hi Baolu,

On Wed, 30 Nov 2022 08:10:55 +0800, Baolu Lu <baolu.lu@linux.intel.com>
wrote:

> > --- a/drivers/iommu/intel/iommu.c
> > +++ b/drivers/iommu/intel/iommu.c
> > @@ -1396,6 +1396,23 @@ static void domain_update_iotlb(struct
> > dmar_domain *domain) spin_unlock_irqrestore(&domain->lock, flags);
> >   }
> >   
> > +/*
> > + * Impacted QAT device IDs ranging from 0x4940 to 0x4943.
> > + * This quirk is exempted from risky_device() check because it applies
> > only
> > + * to the built-in QAT devices.
> > + */  
> 
> How about adding:
> 
> "This quirk is exempted from risky_device() check because it doesn't
> effectively grant additional privileges."
sounds good.

Thanks,

Jacob

      reply	other threads:[~2022-11-30  0:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 17:04 [PATCH v2] iommu/vt-d: Add a fix for devices need extra dtlb flush Jacob Pan
2022-11-29  2:37 ` Tian, Kevin
2022-11-29 17:58   ` Jacob Pan
2022-11-30  0:10 ` Baolu Lu
2022-11-30  0:34   ` Jacob Pan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221129163412.15da3081@jacob-builder \
    --to=jacob.jun.pan@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    --cc=yuzhang.luo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).