From: Jakub Kicinski <kuba@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Richard Cochran" <richardcochran@gmail.com>,
YueHaibing <yuehaibing@huawei.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Naresh Kamboju" <naresh.kamboju@linaro.org>,
Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Florian Fainelli" <f.fainelli@gmail.com>
Subject: Re: [PATCH] net: broadcom: Add PTP_1588_CLOCK_OPTIONAL dependency for BCMGENET under ARCH_BCM2835
Date: Wed, 30 Nov 2022 20:41:11 -0800 [thread overview]
Message-ID: <20221130204111.2287b2c9@kernel.org> (raw)
In-Reply-To: <10c264a3-019e-4473-9c20-9bb0c9af97c3@app.fastmail.com>
On Tue, 29 Nov 2022 12:58:23 +0100 Arnd Bergmann wrote:
> > The original report was for a different bug that resulted in the
> > BROADCOM_PHY driver not being selectable at all.
> >
> > The remaining problem here is this configuration:
> >
> > CONFIG_ARM=y
> > CONFIG_BCM2835=y
> > CONFIG_BCMGENET=y
> > CONFIG_PTP_1588_CLOCK=m
> > CONFIG_PTP_1588_CLOCK_OPTIONAL=m
> > CONFIG_BROADCOM_PHY=m
> >
> > In this case, BCMGENET should 'select BROADCOM_PHY' to make the
> > driver work correctly, but fails to do this because of the
> > dependency. During early boot, this means it cannot access the
> > PHY because that is in a loadable module, despite commit
> > 99addbe31f55 ("net: broadcom: Select BROADCOM_PHY for BCMGENET")
> > trying to ensure that it could.
> >
> > Note that many other ethernet drivers don't have this
> > particular 'select' statement and just rely on the .config
> > to contain a sensible set of drivers. In particular that
> > is true when running 64-bit kernels on the same chip,
> > which is now the normal configuration.
> >
> > The alternative to YueHaibing's fix would be to just revert
> > 99addbe31f55 ("net: broadcom: Select BROADCOM_PHY for BCMGENET")
> > and instead change the defconfig file to include the phy driver,
> > as we do elsewhere.
Ah, got it now, I think. Alternatively we could flip the 'select' to
'depends on' and make the user do the legwork? Enough brain cycles
spend on this simple fix tho, so applying, thanks! :)
next prev parent reply other threads:[~2022-12-01 4:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 11:50 [PATCH] net: broadcom: Add PTP_1588_CLOCK_OPTIONAL dependency for BCMGENET under ARCH_BCM2835 YueHaibing
2022-11-25 11:59 ` Arnd Bergmann
2022-11-29 3:18 ` Jakub Kicinski
2022-11-29 11:56 ` Arnd Bergmann
2022-11-29 11:58 ` Arnd Bergmann
2022-11-29 19:12 ` Florian Fainelli
2022-12-01 4:41 ` Jakub Kicinski [this message]
2022-12-01 4:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130204111.2287b2c9@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).