Hi Javier, On Wed, Nov 30, 2022 at 09:00:03AM +0100, Javier Martinez Canillas wrote: > On 11/28/22 15:53, Maxime Ripard wrote: > > We'll need to use those helpers from drivers too, so let's move it to a > > more visible location. > > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/tests/drm_client_modeset_test.c | 3 +-- > > drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +-- > > drivers/gpu/drm/tests/drm_modes_test.c | 3 +-- > > drivers/gpu/drm/tests/drm_probe_helper_test.c | 3 +-- > > {drivers/gpu/drm/tests => include/drm}/drm_kunit_helpers.h | 0 > > 5 files changed, 4 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/gpu/drm/tests/drm_client_modeset_test.c b/drivers/gpu/drm/tests/drm_client_modeset_test.c > > index 52929536a158..ed2f62e92fea 100644 > > --- a/drivers/gpu/drm/tests/drm_client_modeset_test.c > > +++ b/drivers/gpu/drm/tests/drm_client_modeset_test.c > > @@ -8,12 +8,11 @@ > > #include > > #include > > #include > > +#include > > I wonder if now that this header was moved outside of the tests directory, > if we should add stub functions in the header file that are just defined > but do nothing if CONFIG_DRM_KUNIT_TEST isn't enabled. So that including > it in drivers will be a no-op. > > Or do you plan to conditionally include this header file in drivers? So > that is only included when CONFIG_DRM_KUNIT_TEST is enabled? I'm not entirely sure. I'd expect only the tests to include it, and thus would depend on DRM_KUNIT_TEST already. But we can always add the stubs if it's ever included in a different context. > Another thing that wondered is if we want a different namespace for this > header, i.e: , to make it clear that is > not part of the DRM API but just for testing helpers. If there's a single header, I don't think we need to create the directory. This is also something we can consolidate later on if needed. > But these are open questions really, and they can be done as follow-up: > > Reviewed-by: Javier Martinez Canillas Thanks :) Maxime