From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E698C352A1 for ; Sat, 3 Dec 2022 04:59:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231284AbiLCE7O (ORCPT ); Fri, 2 Dec 2022 23:59:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231225AbiLCE7L (ORCPT ); Fri, 2 Dec 2022 23:59:11 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB1BFC5126; Fri, 2 Dec 2022 20:59:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F0E0560EC4; Sat, 3 Dec 2022 04:59:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D542BC433D6; Sat, 3 Dec 2022 04:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670043549; bh=WLqBpD/hSijALuUZgakx2ku24eQYSRBUVggDObxBitk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TzK10HAu0CIj719qjw8PCN2xzDB73wBFHbXEp/E3lMahLs81IOyNEOfrbIimej+BM QuwIlkQ/V8h9ZaUnCmsPpcXkubbgeRK0Ng60VRClOtHROKE4XcGKMDMzBPFMrlF3k/ 3oa59IA8W22yfIFAspjpqTyqyIFvLRPLPTFZ91QI4YZmaaoIzhMZJUTX3k2mAND1wf +APOJYi7+pvaqPZcMM0BZWE2cJX0UbcJ34wH66XgzjaWUy0p92D1UEZdAHP9zajGHA Q0uWzb47lNPN8R54wz52EgV5/SfoCqoLLvfgaNaMAUeRr+xpb3SFwY9MQcvEg9KgIn aRF9eGyfsdsrg== Date: Fri, 2 Dec 2022 20:59:07 -0800 From: Jakub Kicinski To: Qiheng Lin Cc: , , , , , , , , , Subject: Re: [PATCH] net: microchip: sparx5: Fix missing destroy_workqueue of mact_queue Message-ID: <20221202205907.39eabc1c@kernel.org> In-Reply-To: <20221201134717.25750-1-linqiheng@huawei.com> References: <20221201134717.25750-1-linqiheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Dec 2022 21:47:17 +0800 Qiheng Lin wrote: > The mchp_sparx5_probe() won't destroy workqueue created by > create_singlethread_workqueue() in sparx5_start() when later > inits failed. Add destroy_workqueue in the cleanup_ports case, > also add it in mchp_sparx5_remove() This is a fix so it needs a Fixes tag.