From: Jung Daehwan <dh10.jung@samsung.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Colin Ian King <colin.i.king@gmail.com>,
Artur Bujdoso <artur.bujdoso@gmail.com>,
Juergen Gross <jgross@suse.com>,
Tomer Maimon <tmaimon77@gmail.com>,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/SAMSUNG S3C,
S5P AND EXYNOS ARM ARCHITECTURES"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/SAMSUNG S3C,
S5P AND EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
sc.suh@samsung.com, taehyun.cho@samsung.com,
jh0801.jung@samsung.com, eomji.oh@samsung.com
Subject: Re: [RFC PATCH v1 2/2] usb: host: add xhci-exynos to support Exynos SOCs
Date: Mon, 5 Dec 2022 16:53:42 +0900 [thread overview]
Message-ID: <20221205075342.GG54922@ubuntu> (raw)
In-Reply-To: <92df8e1d-eb7b-ec0b-264f-a1a090cececc@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]
On Mon, Dec 05, 2022 at 08:33:39AM +0100, Krzysztof Kozlowski wrote:
> On 05/12/2022 03:34, Jung Daehwan wrote:
>
> >>> Am I missing something here?
> >>
> >> Because it is not a driver for Exynos... it's a driver for wakelocks for
> >> their specific Android use-cases which the manufacturer ships for their
> >> Android devices. Due to Google GKI, they try to squeeze into upstream.
> >> But this is huge misconception what should go to upstream and Samsung
> >> does not want to keep discussing. They just send random patches and
> >> disappear...
> >>
> >> Best regards,
> >> Krzysztof
> >>
> >>
> >
> > No. It's driver for Exynos. Currently It only has wakelocks but I will
> > submit one by one. Please think as the first patch of exynos not
> > squeezed.
>
> That's not how upstream kernel development works... Your code has
> nothing for Exynos. It's Android driver, not Exynos. If you say there is
> something for Exynos it must be visible here. Wakelocks are not relevant
> to Exynos, so after dropping them there would be empty stub in upstream
> kernel which obviously cannot be accepted.
>
> Best regards,
> Krzysztof
>
>
Well, Exynos only uses wakelocks when I see mainline because it seems no
other driver use it. That's why I thought it could be a exynos specific.
Do you agree that if I put wakelocks into xhci platform driver?
Best Regards,
Jung Daehwan
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2022-12-05 7:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221201021940epcas2p2073f25dad069314022471eaa16d26592@epcas2p2.samsung.com>
2022-12-01 2:13 ` [RFC PATCH v1 0/2] add xhci-exynos to support Samsung Exynos SOCs Daehwan Jung
[not found] ` <CGME20221201021941epcas2p4a536a9eb029a990fcb9f27f2b4668d07@epcas2p4.samsung.com>
2022-12-01 2:13 ` [RFC PATCH v1 1/2] dt-bindings: usb: samsung,exynos-xhci: support Samsung Exynos xHCI Controller Daehwan Jung
2022-12-01 8:59 ` Krzysztof Kozlowski
2022-12-05 2:06 ` Jung Daehwan
2022-12-05 7:31 ` Krzysztof Kozlowski
2022-12-05 7:48 ` Jung Daehwan
2022-12-05 8:02 ` Krzysztof Kozlowski
[not found] ` <CGME20221201021942epcas2p2429ed37e1f6146b6e1a5bef23141b3f7@epcas2p2.samsung.com>
2022-12-01 2:13 ` [RFC PATCH v1 2/2] usb: host: add xhci-exynos to support Exynos SOCs Daehwan Jung
2022-12-01 8:06 ` Greg Kroah-Hartman
2022-12-01 9:01 ` Arnd Bergmann
2022-12-01 10:33 ` Krzysztof Kozlowski
2022-12-02 12:22 ` Mathias Nyman
2022-12-02 12:23 ` Krzysztof Kozlowski
2022-12-02 12:51 ` Greg Kroah-Hartman
2022-12-05 2:34 ` Jung Daehwan
2022-12-05 7:33 ` Krzysztof Kozlowski
2022-12-05 7:53 ` Jung Daehwan [this message]
2022-12-05 8:03 ` Krzysztof Kozlowski
2022-12-05 2:28 ` Jung Daehwan
2022-12-05 2:11 ` Jung Daehwan
2022-12-05 3:30 ` Jung Daehwan
2022-12-05 8:21 ` Greg Kroah-Hartman
2022-12-01 8:03 ` [RFC PATCH v1 0/2] add xhci-exynos to support Samsung " Greg Kroah-Hartman
2022-12-01 8:41 ` Jung Daehwan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205075342.GG54922@ubuntu \
--to=dh10.jung@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=artur.bujdoso@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=eomji.oh@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgross@suse.com \
--cc=jh0801.jung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=sc.suh@samsung.com \
--cc=taehyun.cho@samsung.com \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).