From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
yunfei.dong@mediatek.com
Subject: Re: [PATCH v5 2/3] media: dt-bindings: media: mediatek: Remove "dma-ranges" property for decoder
Date: Mon, 5 Dec 2022 17:32:14 -0300 [thread overview]
Message-ID: <20221205203214.megeq5nr7ksvb5vw@notapiano> (raw)
In-Reply-To: <20221128143832.25584-3-allen-kh.cheng@mediatek.com>
On Mon, Nov 28, 2022 at 10:38:31PM +0800, Allen-KH Cheng wrote:
> Since commit f1ad5338a4d5 ("of: Fix "dma-ranges" handling for bus
> controllers") was merge, we don't need a dma-ranges property for IOMMU
> in mediatek video codec.
This description isn't right, as it gives the impression that the mentioned
commit removed the need for having a dma-ranges property, but that isn't the
case, the property wasn't needed even before that commit. That commit did
however expose the fact that having this property didn't make sense in the first
place.
Here's a suggestion:
The decoder nodes already make use of the iommus property to configure the IOMMU
for address translations, so also having a dma-ranges property doesn't make
sense.
In fact, after commit f1ad5338a4d5 ("of: Fix "dma-ranges" handling for bus
controllers"), having a dma-ranges property causes IOMMU faults.
Remove the dma-ranges property and update the example.
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
next prev parent reply other threads:[~2022-12-05 20:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 14:38 [PATCH v5 0/3] Add vcodec lat and core nodes for mt8192 Allen-KH Cheng
2022-11-28 14:38 ` [PATCH v5 1/3] media: dt-bindings: media: mediatek: Rename child node names for decoder Allen-KH Cheng
2022-12-01 14:57 ` Krzysztof Kozlowski
2022-12-05 21:32 ` Nícolas F. R. A. Prado
2022-11-28 14:38 ` [PATCH v5 2/3] media: dt-bindings: media: mediatek: Remove "dma-ranges" property " Allen-KH Cheng
2022-11-30 11:27 ` AngeloGioacchino Del Regno
2022-12-01 23:14 ` Rob Herring
2022-12-05 20:32 ` Nícolas F. R. A. Prado [this message]
2022-11-28 14:38 ` [PATCH v5 3/3] arm64: dts: mt8192: Add video-codec nodes Allen-KH Cheng
2022-11-30 11:27 ` AngeloGioacchino Del Regno
2022-12-05 21:04 ` Nícolas F. R. A. Prado
2022-12-01 9:12 ` [PATCH v5 0/3] Add vcodec lat and core nodes for mt8192 Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205203214.megeq5nr7ksvb5vw@notapiano \
--to=nfraprado@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).