On Tue, Dec 06, 2022 at 04:10:51PM +0000, Lee Jones wrote: > On Tue, 06 Dec 2022, Uwe Kleine-König wrote: > > > Hey Lee, > > > > On Mon, Nov 21, 2022 at 04:51:21PM +0000, Lee Jones wrote: > > > On Mon, 21 Nov 2022, Uwe Kleine-König wrote: > > > > > > > Hello Lee, > > > > > > > > On Mon, Nov 21, 2022 at 12:32:10PM +0000, Lee Jones wrote: > > > > > On Fri, 18 Nov 2022, Uwe Kleine-König wrote: > > > > > > > > > > > From: Uwe Kleine-König > > > > > > > > > > > > The probe function doesn't make use of the i2c_device_id * parameter so it > > > > > > can be trivially converted. > > > > > > > > > > > > Signed-off-by: Uwe Kleine-König > > > > > > --- > > > > > > drivers/mfd/khadas-mcu.c | 5 ++--- > > > > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > > > > > After a week or so, please collect-up all the tags you have received > > > > > and submit a per-subsystem set for me to hoover up, thanks. > > > > > > > > For mfd I'd do: > > > > > > > > git checkout mfd/for-next > > > > b4 am -P 413-481 20221118224540.619276-1-uwe@kleine-koenig.org > > > > git am ./20221118_uwe_i2c_complete_conversion_to_i2c_probe_new.mbx > > > > git send-email --to .... --cc .... mfd/for-next > > > > > > That's just crazy enough to work. > > > > > > Thanks for the tip. > > > > On irc you said you'd care for application of these patches ("I plan to > > attempt the b4 solution"), they didn't land in next yet. Do you need a > > reminder? Something else? > > I applied them, but they fail to build and I haven't had time to > investigate. I guess they depend on some patches that have been > accepted into another (input?) and are now in -next. Any idea if they > are available on some immutable branch that I can pull from? If in your tree i2c_client_get_device_id() is missing, you want to pull https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/client_device_id_helper-immutable Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |