From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5019CC4708E for ; Wed, 7 Dec 2022 14:29:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230353AbiLGO3S (ORCPT ); Wed, 7 Dec 2022 09:29:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230269AbiLGO2o (ORCPT ); Wed, 7 Dec 2022 09:28:44 -0500 Received: from mail.astralinux.ru (mail.astralinux.ru [217.74.38.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 227EA56EC0; Wed, 7 Dec 2022 06:28:34 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 7390018643B9; Wed, 7 Dec 2022 17:28:32 +0300 (MSK) Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id cMC_BiZcTg-y; Wed, 7 Dec 2022 17:28:32 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 2722D18643BE; Wed, 7 Dec 2022 17:28:32 +0300 (MSK) X-Virus-Scanned: amavisd-new at astralinux.ru Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id IfQygreVYS-r; Wed, 7 Dec 2022 17:28:32 +0300 (MSK) Received: from rbta-msk-lt-106062.astralinux.ru (unknown [10.177.20.20]) by mail.astralinux.ru (Postfix) with ESMTPSA id 8132D18643B9; Wed, 7 Dec 2022 17:28:31 +0300 (MSK) From: Anastasia Belova To: Thomas Bogendoerfer Cc: Anastasia Belova , Jonathan Cameron , Randy Dunlap , Florian Fainelli , Maxime Bizon , Ralf Baechle , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, kernel test robot Subject: [PATCH v2 2/2] MIPS: BCM63xx: Add check for NULL for clk in clk_enable Date: Wed, 7 Dec 2022 17:28:24 +0300 Message-Id: <20221207142824.8706-2-abelova@astralinux.ru> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221207142824.8706-1-abelova@astralinux.ru> References: <20221207142824.8706-1-abelova@astralinux.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Errors from previous version of patch fixed. Check clk for NULL before calling clk_enable_unlocked where clk is dereferenced. There is such check in other implementations of clk_enable. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx= family of SOCs.") Reported-by: kernel test robot Signed-off-by: Anastasia Belova --- arch/mips/bcm63xx/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c index 401140cf36d9..cf303d6e6693 100644 --- a/arch/mips/bcm63xx/clk.c +++ b/arch/mips/bcm63xx/clk.c @@ -362,7 +362,7 @@ static struct clk clk_periph =3D { int clk_enable(struct clk *clk) { if (!clk) - return; + return 0; =20 mutex_lock(&clocks_mutex); clk_enable_unlocked(clk); --=20 2.30.2