From: zhoudan <zhuqiandann@gmail.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, zhoudan8@xiaomi.com
Subject: Re: [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed
Date: Tue, 13 Dec 2022 10:21:00 +0800 [thread overview]
Message-ID: <20221213022100.GA841758@mi-ThinkStation-K> (raw)
In-Reply-To: <Y5ezpOwd8sOTTaW5@google.com>
However, 'f2fs_compressed_file()' only determines whether the file can
be compressed, not whether the file has been compressed. As far as I
know, when compress_mode is user, files marked FI_COMPRESSED_FILE
will be compressed only after 'f2fs_ioc_compress_file()' is called.
On Mon, Dec 12, 2022 at 03:05:08PM -0800, Jaegeuk Kim wrote:
> On 12/12, zhoudan wrote:
> > Maybe I'm not describing it clearly enough, but I think there is
> > something wrong with the logic here.The 'f2fs_release_compress_blocks'
> > method does not determine if the file is compressed, but simply adds
> > the FI_COMPRESS_RELEASED flag.
>
> I firstly lost your point since f2fs_release_compress_blocks() checked
> f2fs_compressed_file().
>
> > In particular, in the current Android system, when the application is
> > installed, the release interface is called by default to release the
> > storage marked as compressed, without checking whether the file is
> > actually compressed. In this case, when compress_mode is set to user,
> > calling the compress interface returns ENVAL and the file cannot be
> > compressed.
> > So I think the implementation of release needs to be modified, and
> > only set FI_COMPRESS_RELEASED when it's really compressed and the
> > storage is released.
> >
> > On Fri, Dec 09, 2022 at 12:19:44PM -0800, Jaegeuk Kim wrote:
> > > On 12/08, zhoudan8 wrote:
> > > > In compress_mode=user, f2fs_release_compress_blocks()
> > > > does not verify whether it has been compressed and
> > > > sets FI_COMPRESS_RELEASED directly. which will lead to
> > > > return -EINVAL after calling compress.
> > > > To fix it,let's do not set FI_COMPRESS_RELEASED if file
> > > > is not compressed.
> > >
> > > Do you mean you want to avoid EINVAL on a file having FI_COMPRESS_RELEASED
> > > with zero i_compr_blokcs?
> > >
> > > I think the current logic is giving the error on a released file already.
> > >
> > > >
> > > > Signed-off-by: zhoudan8 <zhoudan8@xiaomi.com>
> > > > ---
> > > > fs/f2fs/file.c | 3 +--
> > > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > > >
> > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > > > index 82cda1258227..f32910077df6 100644
> > > > --- a/fs/f2fs/file.c
> > > > +++ b/fs/f2fs/file.c
> > > > @@ -3451,14 +3451,13 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg)
> > > > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX);
> > > > if (ret)
> > > > goto out;
> > > > -
> > > > - set_inode_flag(inode, FI_COMPRESS_RELEASED);
> > > > inode->i_ctime = current_time(inode);
> > > > f2fs_mark_inode_dirty_sync(inode, true);
> > > >
> > > > if (!atomic_read(&F2FS_I(inode)->i_compr_blocks))
> > > > goto out;
> > > >
> > > > + set_inode_flag(inode, FI_COMPRESS_RELEASED);
> > > > f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
> > > > filemap_invalidate_lock(inode->i_mapping);
> > > >
> > > > --
> > > > 2.38.1
next prev parent reply other threads:[~2022-12-13 2:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 5:08 [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed zhoudan8
2022-12-09 20:19 ` Jaegeuk Kim
2022-12-12 12:21 ` zhoudan
2022-12-12 23:05 ` Jaegeuk Kim
2022-12-13 2:21 ` zhoudan [this message]
2022-12-16 11:17 ` zhou dan
2023-01-04 2:29 ` Jaegeuk Kim
2023-01-11 2:47 ` zhou dan
2022-12-12 12:38 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213022100.GA841758@mi-ThinkStation-K \
--to=zhuqiandann@gmail.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zhoudan8@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).