linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Jones <pjones@redhat.com>
To: Evgeniy Baskov <baskov@ispras.ru>
Cc: Ard Biesheuvel <ardb@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Andy Lutomirski <luto@kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Alexey Khoroshilov <khoroshilov@ispras.ru>,
	Peter Jones <pjones@redhat.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	joeyli <jlee@suse.com>,
	lvc-project@linuxtesting.org, x86@kernel.org,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH 2/2] efi/x86: don't try to set page attributes on 0-sized regions.
Date: Tue, 13 Dec 2022 13:04:03 -0500	[thread overview]
Message-ID: <20221213180403.1308507-2-pjones@redhat.com> (raw)
In-Reply-To: <20221213180403.1308507-1-pjones@redhat.com>

In "efi/x86: Explicitly set sections memory attributes", the following
region is defined to help compute page permissions:

          /* .setup [image_base, _head] */
          efi_adjust_memory_range_protection(image_base,
                                             (unsigned long)_head - image_base,
                                             EFI_MEMORY_RO | EFI_MEMORY_XP);

In at least some cases, that will result in a size of 0, which will
produce an error and a message on the console, though no actual failure
will be caused in the boot process.

This patch checks that case in efi_adjust_memory_range_protection() and
returns the error without logging.

Signed-off-by: Peter Jones <pjones@redhat.com>
---
 drivers/firmware/efi/libstub/mem.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/firmware/efi/libstub/mem.c b/drivers/firmware/efi/libstub/mem.c
index d52841adcc2..d20b1986c9e 100644
--- a/drivers/firmware/efi/libstub/mem.c
+++ b/drivers/firmware/efi/libstub/mem.c
@@ -247,6 +247,9 @@ efi_status_t efi_adjust_memory_range_protection(unsigned long start,
 	efi_physical_addr_t rounded_start, rounded_end;
 	unsigned long attr_clear;
 
+	if (size == 0)
+		return EFI_INVALID_PARAMETER;
+
 	/*
 	 * This function should not be used to modify attributes
 	 * other than writable/executable.
-- 
2.38.1


  reply	other threads:[~2022-12-13 18:05 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 11:12 [PATCH v3 00/24] x86_64: Improvements at compressed kernel stage Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 01/24] x86/boot: Align vmlinuz sections on page size Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 02/24] x86/build: Remove RWX sections and align on 4KB Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 03/24] x86/boot: Set cr0 to known state in trampoline Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 04/24] x86/boot: Increase boot page table size Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 05/24] x86/boot: Support 4KB pages for identity mapping Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 06/24] x86/boot: Setup memory protection for bzImage code Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 07/24] x86/build: Check W^X of vmlinux during build Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 08/24] x86/boot: Map memory explicitly Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 09/24] x86/boot: Remove mapping from page fault handler Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 10/24] efi/libstub: Move helper function to related file Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 11/24] x86/boot: Make console interface more abstract Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 12/24] x86/boot: Make kernel_add_identity_map() a pointer Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 13/24] x86/boot: Split trampoline and pt init code Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 14/24] x86/boot: Add EFI kernel extraction interface Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 15/24] efi/x86: Support extracting kernel from libstub Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 16/24] x86/boot: Reduce lower limit of physical KASLR Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 17/24] x86/boot: Reduce size of the DOS stub Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 18/24] tools/include: Add simplified version of pe.h Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 19/24] x86/build: Cleanup tools/build.c Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 20/24] x86/build: Make generated PE more spec compliant Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 21/24] efi/x86: Explicitly set sections memory attributes Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 22/24] efi/libstub: Add memory attribute protocol definitions Evgeniy Baskov
2023-01-31  8:37   ` Ard Biesheuvel
2023-01-31 10:00     ` Evgeniy Baskov
2023-01-31 10:01       ` Ard Biesheuvel
2022-11-22 11:12 ` [PATCH v3 23/24] efi/libstub: Use memory attribute protocol Evgeniy Baskov
2022-11-22 11:12 ` [PATCH v3 24/24] efi/libstub: Make memory protection warnings include newlines Evgeniy Baskov
2022-12-13 18:03 ` [PATCH v3 00/24] x86_64: Improvements at compressed kernel stage Peter Jones
2022-12-13 18:04   ` [PATCH 1/2] efi/x86: don't set unsupported memory attributes Peter Jones
2022-12-13 18:04     ` Peter Jones [this message]
2022-12-13 18:13   ` [PATCH v3 00/24] x86_64: Improvements at compressed kernel stage Peter Jones
2022-12-13 22:16     ` Evgeniy Baskov
2022-12-14 10:09       ` Ard Biesheuvel
2022-12-14 11:49         ` Evgeniy Baskov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221213180403.1308507-2-pjones@redhat.com \
    --to=pjones@redhat.com \
    --cc=ardb@kernel.org \
    --cc=baskov@ispras.ru \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=jlee@suse.com \
    --cc=khoroshilov@ispras.ru \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=mario.limonciello@amd.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).