From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 429A6C001B2 for ; Wed, 14 Dec 2022 16:21:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238941AbiLNQVm (ORCPT ); Wed, 14 Dec 2022 11:21:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238711AbiLNQVf (ORCPT ); Wed, 14 Dec 2022 11:21:35 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C92282C9; Wed, 14 Dec 2022 08:21:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671034893; x=1702570893; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sugwmwrUIAbwUVd9kUUcbnqMzWklglljdUgzpTG789o=; b=HGnDWEVEEFs82G5oXn1K7JNd1hyZhblpDhYzT/48TneA7w9Hi1QUek5s YS1RcYq9PW4xVQ2RYbAIoxgh04wfoffBtejEO4tX35Umv0JE8C0xWldEJ rGfIBd/AOoT6ASYeZRe5CNLe9qgz7F9DT0kK6/VIuHIOjAusqHnKc0W8e YK61SXjAen1i72ek46pYydcKTNrDiGtXQHhnvwU+J/b6ESj1WDrclo5wY gtZCyC3iBLeI0Fmr6sgsHOK4+5d732V+YgABIVdgL/1EjNtHR2PmCwwNW nqC32EZ8EllECpFl+mXn5bReoihuL89Ukv3eY6wdOclvdHaa5Qk4kCqiH w==; X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="404716272" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="404716272" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 08:21:32 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="642559944" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="642559944" Received: from joe-255.igk.intel.com (HELO localhost) ([172.22.229.67]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 08:21:20 -0800 Date: Wed, 14 Dec 2022 17:21:17 +0100 From: Stanislaw Gruszka To: Eric Dumazet Cc: "Jason A. Donenfeld" , Vignesh Raghavendra , Peter Zijlstra , Joonsoo Kim , Roman Gushchin , Rasmus Villemoes , Alexei Starovoitov , dri-devel@lists.freedesktop.org, Song Liu , linux-mtd@lists.infradead.org, Stanislav Fomichev , "H. Peter Anvin" , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Daniel Borkmann , Richard Weinberger , x86@kernel.org, John Fastabend , Andrii Nakryiko , ilay.bahat1@gmail.com, Ingo Molnar , David Rientjes , Yonghong Song , Paolo Abeni , "James E.J. Bottomley" , Petr Mladek , david.keisarschm@mail.huji.ac.il, Dave Hansen , Tvrtko Ursulin , Miquel Raynal , intel-gfx@lists.freedesktop.org, Steven Rostedt , KP Singh , Jakub Kicinski , Rodrigo Vivi , Borislav Petkov , Hannes Reinecke , Andy Lutomirski , Jiri Pirko , Thomas Gleixner , Andy Shevchenko , bpf@vger.kernel.org, Vlastimil Babka , Hao Luo , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pekka Enberg , Sergey Senozhatsky , aksecurity@gmail.com, Jiri Olsa , Andrew Morton , Martin KaFai Lau , "David S. Miller" Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state Message-ID: <20221214162117.GC1062210@linux.intel.com> References: <20221214123358.GA1062210@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2022 at 04:15:49PM +0100, Eric Dumazet wrote: > On Wed, Dec 14, 2022 at 1:34 PM Stanislaw Gruszka > wrote: > > > > On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote: > > > Please CC me on future revisions. > > > > > > As of 6.2, the prandom namespace is *only* for predictable randomness. > > > There's no need to rename anything. So nack on this patch 1/5. > > > > It is not obvious (for casual developers like me) that p in prandom > > stands for predictable. Some renaming would be useful IMHO. > > Renaming makes backports more complicated, because stable teams will > have to 'undo' name changes. > Stable teams are already overwhelmed by the amount of backports, and > silly merge conflicts. Since when backporting problems is valid argument for stop making changes? That's new for me. > linux kernel is not for casual readers. Sure. Regards Stanislaw