From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6D1C4332F for ; Thu, 15 Dec 2022 15:14:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229774AbiLOPN7 (ORCPT ); Thu, 15 Dec 2022 10:13:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230141AbiLOPN1 (ORCPT ); Thu, 15 Dec 2022 10:13:27 -0500 X-Greylist: delayed 524 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 15 Dec 2022 07:12:44 PST Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFA4932B8F; Thu, 15 Dec 2022 07:12:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3zeWx/VcZJ+nKDoxQSjrPrYjj2F0B/NTv4M2nB0Taxo=; b=XGVRecjPvKN1DiEoK3zrmKwJgf dWEDw4jOTpFgBvU8dBgihUP5XjHpeVRupNcj9IXw94trWULMNnwKW6wd8vZm6vJvGCGOY2VGxY52j vzJ+xy7fEf/F7RUY0ktMDb2XSAVik9jhS46pHut3Gv9K2eA6+iID9ubN+OgosU4QMFZc=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:48106 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1p5puc-0000OA-0h; Thu, 15 Dec 2022 10:12:42 -0500 Date: Thu, 15 Dec 2022 10:12:41 -0500 From: Hugo Villeneuve To: Alexandre Belloni Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <20221215101241.993999be8b51f133fb11bfba@hugovil.com> In-Reply-To: References: <20220309162301.61679-1-alexandre.belloni@bootlin.com> <20220309162301.61679-11-alexandre.belloni@bootlin.com> <20220310110918.41a681474f5a0e11abdedc39@hugovil.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH 11/29] rtc: pcf2127: set RTC_FEATURE_ALARM_RES_2S X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Mar 2022 21:58:49 +0100 Alexandre Belloni wrote: > On 10/03/2022 11:09:18-0500, Hugo Villeneuve wrote: > > On Wed, 9 Mar 2022 17:22:42 +0100 > > Alexandre Belloni wrote: > > > > > The PCF2127 doesn't support UIE because setting an alarm to fire every > > > second confuses the chip and the fastest we can go is an alarm every 2 > > > seconds. > > > > Hi Alexandre, > > can you describe what "confuses the chip" means? > > > > In my experimental PCF2131 driver, I activated UIE and it seems to be working fine at 1s intervals, but since it is similar to PCF2127, maybe there is still a problem and I just didn't see it. > > > > Did you remove uie_unsupported? Else, you may have been using uie > emulation. In my tests last year, the pcf2127 was failing to reassert > the interrupt if an alarm was set every second. The same happens on > other NXP based RTCs (i.e. including microcrystal ones). > > I'm going to test again soon (and also reply to your series). Hi Alexandre, after 9 months, I decided to resend my PCF2131 driver serie (V3), rebased on your latest rtc-next branch. I would appreciate if you or someone could take a look at it and comment. Thank you, Hugo Villeneuve > > > Signed-off-by: Alexandre Belloni > > > --- > > > drivers/rtc/rtc-pcf2127.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c > > > index f8469b134411..63b275b014bd 100644 > > > --- a/drivers/rtc/rtc-pcf2127.c > > > +++ b/drivers/rtc/rtc-pcf2127.c > > > @@ -656,6 +656,7 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap, > > > pcf2127->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; > > > pcf2127->rtc->range_max = RTC_TIMESTAMP_END_2099; > > > pcf2127->rtc->set_start_time = true; /* Sets actual start to 1970 */ > > > + set_bit(RTC_FEATURE_ALARM_RES_2S, pcf2127->rtc->features); > > > clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, pcf2127->rtc->features); > > > clear_bit(RTC_FEATURE_ALARM, pcf2127->rtc->features); > > > > > > -- > > > 2.35.1 > > > > > > > > > -- > > Hugo Villeneuve > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > -- Hugo Villeneuve