From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1199AC4332F for ; Mon, 19 Dec 2022 18:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232525AbiLSSca (ORCPT ); Mon, 19 Dec 2022 13:32:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232512AbiLSSbp (ORCPT ); Mon, 19 Dec 2022 13:31:45 -0500 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CCE11401A; Mon, 19 Dec 2022 10:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=v4wAWSgxyhaRB7Y8Dgp+aaoh5EMx3BiZ3LpgdRNFuKM=; b=vQcFZ1klU2teUayG3dFn8DvFCV 7hk2s9B4vxD/y0qaf5KvKBx82x2sT8SXy6OCIDPziELVb97LUETR2LOh0Ps+XdM28vPF9fkEyk56v Q/DxyhiTI/LvOGkiNXV6ZxOoclIvotqbcjZcQcuu4w4KDb03ruDGzXsGGf3WGPvd8+4s=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:48612 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1p7Kut-0003U7-JK; Mon, 19 Dec 2022 13:31:12 -0500 Date: Mon, 19 Dec 2022 13:31:11 -0500 From: Hugo Villeneuve To: Bruno Thomsen Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Hugo Villeneuve Message-Id: <20221219133111.6d6af8e601ca019f26fcb382@hugovil.com> In-Reply-To: References: <20221215150214.1109074-1-hugo@hugovil.com> <20221215150214.1109074-15-hugo@hugovil.com> <20221219112542.fb30929b8b91255dcba5a289@hugovil.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH v3 14/14] dt-bindings: rtc: pcf2127: add PCF2131 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Dec 2022 18:18:58 +0100 Bruno Thomsen wrote: > Den man. 19. dec. 2022 kl. 17.25 skrev Hugo Villeneuve : > > > > On Mon, 19 Dec 2022 10:14:10 +0100 > > Bruno Thomsen wrote: > > > > > Den tor. 15. dec. 2022 kl. 16.19 skrev Hugo Villeneuve : > > > > > > > > From: Hugo Villeneuve > > > > > > > > Add support for new NXP RTC PCF2131. > > > > > > > > Signed-off-by: Hugo Villeneuve > > > > --- > > > > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > > index cde7b1675ead..a8f8c23da4d8 100644 > > > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > > @@ -14,7 +14,9 @@ maintainers: > > > > > > > > properties: > > > > compatible: > > > > - const: nxp,pcf2127 > > > > + enum: > > > > + - nxp,pcf2127 > > > > + - nxp,pcf2131 > > > > > > The enum is incomplete as pcf2127_of_match struct also contains: > > > nxp,pcf2129 > > > ncp,pca2129 > > > > > > /Bruno > > > > Hi, > > if I understand correctly, this means that the pca2129 and pcf2129 entries are already missing and should be added in a fix or a patch outside the scope of my new driver... > > > > Correct, I just noticed while doing review. Hi, I will send a separate patch very soon. Thank you, Hugo. V. > > > > reg: > > > > maxItems: 1 > > > > -- > > > > 2.30.2 > > > > > > > > > > > > > -- > > Hugo Villeneuve > -- Hugo Villeneuve