Hi Hal, I love your patch! Perhaps something to improve: [auto build test WARNING on 830b3c68c1fb1e9176028d02ef86f3cf76aa2476] url: https://github.com/intel-lab-lkp/linux/commits/Hal-Feng/Basic-clock-and-reset-support-for-StarFive-JH7110-RISC-V-SoC/20221220-090131 base: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476 patch link: https://lore.kernel.org/r/20221220005054.34518-6-hal.feng%40starfivetech.com patch subject: [PATCH v3 05/11] reset: starfive: Rename "jh7100" to "jh71x0" for the common code config: riscv-allyesconfig compiler: riscv64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d3dcb30354b5f53a536ca6db2fa04710494cabe0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Hal-Feng/Basic-clock-and-reset-support-for-StarFive-JH7110-RISC-V-SoC/20221220-090131 git checkout d3dcb30354b5f53a536ca6db2fa04710494cabe0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/reset/starfive/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/reset/starfive/reset-starfive-jh71x0.c:106:5: warning: no previous prototype for 'reset_starfive_jh71x0_register' [-Wmissing-prototypes] 106 | int reset_starfive_jh71x0_register(struct device *dev, struct device_node *of_node, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/reset_starfive_jh71x0_register +106 drivers/reset/starfive/reset-starfive-jh71x0.c 105 > 106 int reset_starfive_jh71x0_register(struct device *dev, struct device_node *of_node, -- 0-DAY CI Kernel Test Service https://01.org/lkp