From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A0EC4332F for ; Thu, 22 Dec 2022 17:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230032AbiLVRlB (ORCPT ); Thu, 22 Dec 2022 12:41:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229763AbiLVRk7 (ORCPT ); Thu, 22 Dec 2022 12:40:59 -0500 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 537CC2098C for ; Thu, 22 Dec 2022 09:40:58 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6A42F5C00AB; Thu, 22 Dec 2022 12:40:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 22 Dec 2022 12:40:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1671730857; x=1671817257; bh=ljQIwBiT6P nqZfUaJG0+9MBh7Tku4aeaSACQIIP1dU8=; b=TjOhLknhJMWWmT8aTUKeKAYXbg WaHrYJYv8Y4S3RvrbTMlMpKhWwFyEUHIq3Ssz07ZIAOsra8QW62NivQBkb7wVRM0 uSPNsg0sepUm1O5EJxwyHiDIBKXy/iWDqtWdQq45uVcgNkgTHjsNV0tukITAE9Kf 9fzv9vSQ5i9WAGdMxzXeqGAa74A2lK0XxdV/gWXBqAkGc25tHFo5TJ9hz/QGA3aJ 8ujqDLnDj6sEmEpVWcXrocKJFAfYZB0JUqU7hz1RfeLJ15qjm87YqAqdYLzcVKwz kjreOw/wJf5MB3k25xBbS2YvsB2M4MZHJBMIuG3i25kxO+fJGCSRCVFoFvZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1671730857; x=1671817257; bh=ljQIwBiT6PnqZfUaJG0+9MBh7Tku 4aeaSACQIIP1dU8=; b=alzusaQxC2H4zn3JmcHu45Td350zSpjO3obF2/rzo9hA miTvotG2GKJBFZeMGnZb+fjAsRCs6VdtF+1pjKHnpLViJQ75KkN0tPTovTopgtm0 1WnfqJdIMpECjPyfGXW9fMVZ1Hao5FunYbEgWEUMyQ0xdg3vd/ganWQD1yK2pTYE lpOACcD72oLJxDWU0xJAkGvFgJRaB4XWXus0VTJeW9eaLxBiSvBsC4TWBx1Zu/qQ rQQyilIWZwlBr/r47UPaykWJUu/U7WVNO7ZxSwIoVrA6BmCi2pkazXvaZD6M+eOG dwX6vF9uCey7eLWv0CWwKaagbKdfw0Fj8xKjfvQr4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrhedtgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpedtleekjeeiudefvdfhieffteelhfeivdeliefgieeugffhvdelieffjeei geetjeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggt hh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Dec 2022 12:40:55 -0500 (EST) Date: Thu, 22 Dec 2022 18:40:54 +0100 From: Maxime Ripard To: Michael Rodin Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Dave Airlie , Alex Deucher , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, michael@rodin.online, erosca@de.adit-jv.com, laurent.pinchart@ideasonboard.com Subject: Re: [PATCH] drm: override detected status for connectors which are forced on Message-ID: <20221222174054.tsj4rfzejrl3cc7g@penduick> References: <20221107123657.24vbgep3jqeklb2s@houat> <20221215170359.92422-1-mrodin@de.adit-jv.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p37xnirrqan5m5yb" Content-Disposition: inline In-Reply-To: <20221215170359.92422-1-mrodin@de.adit-jv.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --p37xnirrqan5m5yb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Dec 15, 2022 at 06:03:59PM +0100, Michael Rodin wrote: > The detected status of a connector should be ignored when a connector is > forced as hinted in the commit d50ba256b5f1 ("drm/kms: start > adding command line interface using fb."). One negative side effect of > not ignoring this is observed on the RCar3 SoCs which use the dw-hdmi > driver. It continues executing drm_helper_hpd_irq_event even if its > connector is forced to ON. As consequence drm_helper_hpd_irq_event calls > "detect" so the connector status is updated to "disconnected": >=20 > [ 420.201527] [drm:drm_helper_hpd_irq_event] [CONNECTOR:76:HDMI-A-1] sta= tus updated from connected to disconnected >=20 > This status is corrected by drm_helper_probe_single_connector_modes short= ly > after this because this function checks if a connector is forced: >=20 > [ 420.218703] [drm:drm_helper_probe_single_connector_modes] [CONNECTOR:7= 6:HDMI-A-1] status updated from disconnected to connected >=20 > To avoid similar issues this commit adapts functions which call "detect" > so they check additionally if a connector is forced and override the stat= us > returned by "detect". >=20 > Fixes: 816da85a0990 ("drm: handle HPD and polled connectors separately") > Signed-off-by: Michael Rodin As reported here, this breaks vc4, and probably i915: https://lore.kernel.org/dri-devel/20221107123657.24vbgep3jqeklb2s@houat/ Maxime --p37xnirrqan5m5yb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCY6SWpgAKCRDj7w1vZxhR xRloAQDBPrPvSE361m058JRvYOTalUo/1dvgEQncDKUjTGzGkwEArxTusD7G9wLm INu9zWHVV0EzE8s9rPJ1rnmAq2ukAAQ= =0ovf -----END PGP SIGNATURE----- --p37xnirrqan5m5yb--